chrome/browser/chromeos/login/screens/user_selection_screen.cc - Issue 1128923006: Do not invalidate OAuth token status user when token handle is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/user_selection_screen.cc

Issue 1128923006: Do not invalidate OAuth token status user when token handle is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/existing_user_controller.cc ('k') | chrome/browser/chromeos/login/signin/token_handle_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screens/user_selection_screen.cc

diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.cc b/chrome/browser/chromeos/login/screens/user_selection_screen.cc

index 4b633308ce49b9e76422b87a08c32181cdc03324..814faee0196f4f8509c36bf03975a9ca2b9b8d0e 100644

--- a/chrome/browser/chromeos/login/screens/user_selection_screen.cc

+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.cc

@@ -433,9 +433,7 @@ void UserSelectionScreen::OnUserStatusChecked(

TokenHandleUtil::TokenHandleStatus status) {

if (status == TokenHandleUtil::INVALID) {

RecordReauthReason(user_id, ReauthReason::INVALID_TOKEN_HANDLE);

- user_manager::UserManager::Get()->SaveUserOAuthStatus(

- user_id, user_manager::User::OAUTH2_TOKEN_STATUS_INVALID);

- token_handle_util_->DeleteToken(user_id);

+ token_handle_util_->MarkHandleInvalid(user_id);

SetAuthType(user_id, ONLINE_SIGN_IN, base::string16());

}