Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1128683004: Revert to using system AlertDialog.Builder. (Closed)

Created:
5 years, 7 months ago by aurimas (slooooooooow)
Modified:
5 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert to using system AlertDialog.Builder. Due to b/20882793 bug in AppCompat we need to use system AlertDialog.Builder for all the dialogs that contain EditText. BUG=484658 Committed: https://crrev.com/7894f1a861c1256a7d0c43daf4ce641e5b9b6f9e Cr-Commit-Position: refs/heads/master@{#329688}

Patch Set 1 #

Patch Set 2 : Fix the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/android/java/res/layout/add_to_homescreen_dialog.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
aurimas (slooooooooow)
PTAL. This makes all to homescreen dialog holo again for pre-L devices.
5 years, 7 months ago (2015-05-13 01:05:01 UTC) #2
gone
lgtm
5 years, 7 months ago (2015-05-13 17:46:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128683004/1
5 years, 7 months ago (2015-05-13 17:49:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/15988)
5 years, 7 months ago (2015-05-13 18:17:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128683004/20001
5 years, 7 months ago (2015-05-13 18:23:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 18:55:57 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:56:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7894f1a861c1256a7d0c43daf4ce641e5b9b6f9e
Cr-Commit-Position: refs/heads/master@{#329688}

Powered by Google App Engine
This is Rietveld 408576698