android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 11280284: onShowCustomView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 11280284: onShowCustomView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix NullContentsClient compilation error #2 Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index f7c425929f540dd8f5c0b9aab1e9a88dd2507a04..106c30eae21d6b8c1eba3e06c8b616f9c199616d 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -13,9 +13,11 @@ import android.os.Looper;

import android.os.Message;

import android.util.Log;

import android.view.KeyEvent;

+import android.view.View;

import android.webkit.ConsoleMessage;

import android.webkit.GeolocationPermissions;

import android.webkit.ValueCallback;

+import android.webkit.WebChromeClient;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

@@ -282,6 +284,9 @@ public abstract class AwContentsClient extends ContentViewClient {

public abstract void onReceivedError(int errorCode, String description, String failingUrl);

+ public abstract void onShowCustomView(View view,

+ int requestedOrientation, WebChromeClient.CustomViewCallback callback);

//--------------------------------------------------------------------------------------------

// Stuff that we ignore since it only makes sense for Chrome browser

//--------------------------------------------------------------------------------------------