onShowCustomView

android_webview/java/src/org/chromium/android_webview/AwResource.java

Index: android_webview/java/src/org/chromium/android_webview/AwResource.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwResource.java b/android_webview/java/src/org/chromium/android_webview/AwResource.java
index e98be0b03513cbc82319c6ba883ed77cc59b8df5..8d65e16637c2146ebf41a7febafdb83b4f655187 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwResource.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwResource.java
@@ -33,6 +33,13 @@ public class AwResource {
     // String resource ID for the default text encoding to use.
     public static int STRING_DEFAULT_TEXT_ENCODING;
 
+    // String for full screen video.
+    public static int STRING_VIDEO_INVALID_PLAYBACK;

[benm (inactive), 2012/12/10 10:54:35]

As these are resources defined in content/, you should be able to wire them up
directly in the glue layer (see ResourceProvider.java), and just reference them
as org.chromium.content.R.string.xxxxx.

This file is only used for resources that webview needs not defined in content/.

[acleung, 2013/01/07 23:40:03]

I don't fully follow. I am getting these resource in
frameworks/base/core/res/res/values/strings.xml.

Or are you suggesting that I add these resource in Chromium?

[benm (inactive), 2013/01/08 12:31:51]

You're right to get them from the android framework, but this isn't the correct
place in android_webview to do the mapping. Constants for these resources are
already defined in org.chromium.content.R.string (see
./content/public/android/java/resource_map/org/chromium/content/R.java). So we
just need to map those resources to the android framework ones and that's done
in ResourceProvider.java in the glue layer. And then wherever you need to
reference the string you'd just use org.chromium.content.R.string.XXX instead of
getters here.

+    public static int STRING_VIDEO_ERROR_UNKNOWN;
+    public static int STRING_VIDEO_ERROR_BUTTON;
+    public static int STRING_VIDEO_ERROR_TITLE;
+    public static int STRING_VIDEO_LOADING;
+
     // The embedder should inject a Resources object that will be used
     // to resolve Resource IDs into the actual resources.
     private static Resources sResources;
@@ -48,6 +55,26 @@ public class AwResource {
         sResourceCache = new HashMap<Integer, SoftReference<String> >();
     }
 
+    public static String getVideoInvalidPlayback() {
+        return getResource(STRING_VIDEO_INVALID_PLAYBACK, TYPE_STRING);
+    }
+
+    public static String getVideoErrorUnknown() {
+        return getResource(STRING_VIDEO_ERROR_UNKNOWN, TYPE_STRING);
+    }
+
+    public static String getVideoErrorButton() {
+        return getResource(STRING_VIDEO_ERROR_BUTTON, TYPE_STRING);
+    }
+
+    public static String getVideoErrorTitle() {
+        return getResource(STRING_VIDEO_ERROR_TITLE, TYPE_STRING);
+    }
+
+    public static String getVideoLoading() {
+        return getResource(STRING_VIDEO_LOADING, TYPE_STRING);
+    }
+
     @CalledByNative
     public static String getDefaultTextEncoding() {
         return getResource(STRING_DEFAULT_TEXT_ENCODING, TYPE_STRING);