Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 11280279: Whitelist QuadF from ChromeClassTester checks (Closed)

Created:
8 years ago by jamesr
Modified:
8 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, pam+watch_chromium.org, Nico
Visibility:
Public.

Description

Whitelist QuadF from ChromeClassTester checks There's a measurable (2.3-3%) perf improvement from inlining QuadF's dtor and ctor, even though FindBadConstructs thinks it's too large. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/clang/plugins/ChromeClassTester.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
8 years ago (2012-12-03 19:08:14 UTC) #1
Elliot Glaysher
On 2012/12/03 19:08:14, jamesr wrote: Sorry, I just realized this was a separate patch that ...
8 years ago (2012-12-03 22:52:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11280279/1
8 years ago (2012-12-03 23:06:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-04 02:32:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11280279/1
8 years ago (2012-12-04 02:35:15 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-04 02:52:36 UTC) #6
Message was sent while issue was closed.
Change committed as 170868

Powered by Google App Engine
This is Rietveld 408576698