Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 11280270: Remove TabContentsContainerGtk from ConstrainedWebDialogDelegateGtk. (Closed)

Created:
8 years ago by Avi (use Gerrit)
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove TabContentsContainerGtk from ConstrainedWebDialogDelegateGtk. BUG=107201 TEST=no visible change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170823

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc View 1 4 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
This is along the lines of what you did earlier. I need this gone, but ...
8 years ago (2012-12-01 21:29:53 UTC) #1
Greg Billock
On 2012/12/01 21:29:53, Avi wrote: > This is along the lines of what you did ...
8 years ago (2012-12-03 16:59:20 UTC) #2
Avi (use Gerrit)
Can you give this a quick test? I don't have a checkout available.
8 years ago (2012-12-03 17:18:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11280270/3
8 years ago (2012-12-03 19:17:57 UTC) #4
commit-bot: I haz the power
Presubmit check for 11280270-3 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-03 19:17:59 UTC) #5
Avi (use Gerrit)
erg: OWNER
8 years ago (2012-12-03 19:48:20 UTC) #6
Elliot Glaysher
stampity lgtm
8 years ago (2012-12-03 20:00:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11280270/3
8 years ago (2012-12-03 20:11:37 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-03 22:09:35 UTC) #9
Message was sent while issue was closed.
Change committed as 170823

Powered by Google App Engine
This is Rietveld 408576698