[NaCl SDK] Add arm gcc toolchain support to the SDK

[NaCl SDK] Add arm gcc toolchain support to the SDK

arm toolchain is now included in the SDK.

All examples and libraries are compiled with arm toolchain.
build_sdk now calls download_toolchains directly rather
than running all of run_hooks.

BUG=153938
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172272

[Sam Clegg, 2012-11-30 19:05:10]

https://codereview.chromium.org/11280256/diff/2003/native_client_sdk/src/buil...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/11280256/diff/2003/native_client_sdk/src/buil...
native_client_sdk/src/build_tools/build_sdk.py:507: print '%s="%s"' % (key,
value)
I added more logging here, which I found useful but maybe
unneeded?

https://codereview.chromium.org/11280256/diff/2003/native_client_sdk/src/buil...
native_client_sdk/src/build_tools/build_sdk.py:685: print "Generting Makefiles:
%s" % str(args)
Extra logging, maybe not needed?

This is another on of the cases where we are calling out
to a python library, but calling it with command line args
which seems a little strange.  I think we should either call
as a subprocess, or call into as a library.

[binji, 2012-12-03 19:48:47]

lgtm

https://codereview.chromium.org/11280256/diff/10001/native_client_sdk/src/bui...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/11280256/diff/10001/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/build_sdk.py:424: tcdir)
nit: align with (

https://codereview.chromium.org/11280256/diff/10001/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/build_sdk.py:506: print '%s="%s"' % (key,
value)
useful to keep?

https://codereview.chromium.org/11280256/diff/10001/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/build_sdk.py:684: print "Generting Makefiles:
%s" % str(args)
Generating

[binji, 2012-12-03 19:52:44]

https://codereview.chromium.org/11280256/diff/2003/native_client_sdk/src/buil...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/11280256/diff/2003/native_client_sdk/src/buil...
native_client_sdk/src/build_tools/build_sdk.py:685: print "Generting Makefiles:
%s" % str(args)
On 2012/11/30 19:05:11, Sam Clegg wrote:
> Extra logging, maybe not needed?
> 
> This is another on of the cases where we are calling out
> to a python library, but calling it with command line args
> which seems a little strange.  I think we should either call
> as a subprocess, or call into as a library.

I half agree with this -- on the one hand, it is ugly building commandline
parameters to pass to a python script. On the other, it is a defined interface
and adding a new library function would mean defining another interface that
could potentially break in different ways than the commandline interface.

[commit-bot: I haz the power, 2012-12-11 02:30:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/11280256/26001

[commit-bot: I haz the power, 2012-12-11 07:27:57]

Change committed as 172272