Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: webkit/glue/fling_animator_impl_android.cc

Issue 11280255: Removed reference to unnecessary WebFlingAnimator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: proof-reading Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/fling_animator_impl_android.h ('k') | webkit/glue/webkitplatformsupport_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/fling_animator_impl_android.cc
diff --git a/webkit/glue/fling_animator_impl_android.cc b/webkit/glue/fling_animator_impl_android.cc
index dfe1ada4f7ab017f8252a85e22a46560d49d187a..b4ba4478160c3fd461925009d79b5ebc45cb805c 100644
--- a/webkit/glue/fling_animator_impl_android.cc
+++ b/webkit/glue/fling_animator_impl_android.cc
@@ -8,6 +8,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/logging.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebGestureCurveTarget.h"
+#include "third_party/WebKit/Source/Platform/chromium/public/WebPoint.h"
#include "ui/gfx/vector2d.h"
using base::android::AttachCurrentThread;
@@ -48,29 +49,28 @@ FlingAnimatorImpl::~FlingAnimatorImpl()
{
}
-void FlingAnimatorImpl::startFling(const WebKit::WebFloatPoint& velocity,
- const WebKit::WebRect& /* range */)
+void FlingAnimatorImpl::StartFling(const gfx::PointF& velocity)
{
- // Ignore "range" as it's always empty -- see http://webkit.org/b/96403
+ // No bounds on the fling. See http://webkit.org/b/96403
// Instead, use the largest possible bounds for minX/maxX/minY/maxY. The
// compositor will ignore any attempt to scroll beyond the end of the page.
- DCHECK(velocity.x || velocity.y);
+ DCHECK(velocity.x() || velocity.y());
if (is_active_)
- cancelFling();
+ CancelFling();
is_active_ = true;
JNIEnv* env = AttachCurrentThread();
env->CallVoidMethod(java_scroller_.obj(), fling_method_id_, 0, 0,
- static_cast<int>(velocity.x),
- static_cast<int>(velocity.y),
+ static_cast<int>(velocity.x()),
+ static_cast<int>(velocity.y()),
INT_MIN, INT_MAX, INT_MIN, INT_MAX);
CheckException(env);
}
-void FlingAnimatorImpl::cancelFling()
+void FlingAnimatorImpl::CancelFling()
{
if (!is_active_)
return;
@@ -81,7 +81,7 @@ void FlingAnimatorImpl::cancelFling()
CheckException(env);
}
-bool FlingAnimatorImpl::updatePosition()
+bool FlingAnimatorImpl::UpdatePosition()
{
JNIEnv* env = AttachCurrentThread();
bool result = env->CallBooleanMethod(java_scroller_.obj(),
@@ -90,10 +90,10 @@ bool FlingAnimatorImpl::updatePosition()
return is_active_ = result;
}
-WebKit::WebPoint FlingAnimatorImpl::getCurrentPosition()
+gfx::Point FlingAnimatorImpl::GetCurrentPosition()
{
JNIEnv* env = AttachCurrentThread();
- WebKit::WebPoint position(
+ gfx::Point position(
env->CallIntMethod(java_scroller_.obj(), getX_method_id_),
env->CallIntMethod(java_scroller_.obj(), getY_method_id_));
CheckException(env);
@@ -102,10 +102,10 @@ WebKit::WebPoint FlingAnimatorImpl::getCurrentPosition()
bool FlingAnimatorImpl::apply(double time,
WebKit::WebGestureCurveTarget* target) {
- if (!updatePosition())
+ if (!UpdatePosition())
return false;
- gfx::Point current_position = getCurrentPosition();
+ gfx::Point current_position = GetCurrentPosition();
gfx::Vector2d diff(current_position - last_position_);
WebKit::WebPoint scroll_amount(diff.x(), diff.y());
target->scrollBy(scroll_amount);
@@ -117,7 +117,7 @@ FlingAnimatorImpl* FlingAnimatorImpl::CreateAndroidGestureCurve(
const WebKit::WebFloatPoint& velocity,
const WebKit::WebSize&) {
FlingAnimatorImpl* gesture_curve = new FlingAnimatorImpl();
- gesture_curve->startFling(velocity, WebKit::WebRect());
+ gesture_curve->StartFling(velocity);
return gesture_curve;
}
« no previous file with comments | « webkit/glue/fling_animator_impl_android.h ('k') | webkit/glue/webkitplatformsupport_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698