Removed reference to unnecessary WebFlingAnimator.

Removed reference to unnecessary WebFlingAnimator.

BUG=157656
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170857

[rjkroege, 2012-11-30 19:27:44]

please take a look.

[jamesr, 2012-12-01 01:47:19]

https://codereview.chromium.org/11280255/diff/2001/webkit/glue/fling_animator...
File webkit/glue/fling_animator_impl_android.h (right):

https://codereview.chromium.org/11280255/diff/2001/webkit/glue/fling_animator...
webkit/glue/fling_animator_impl_android.h:34: void startFling(const
WebKit::WebFloatPoint& velocity,
if this isn't implementing exposed API and is just a chromium implementation, it
should be using gfx:: geometry types. I think you want gfx::PointF and gfx::Rect
here.

WebKit:: geometry types should be used only for crossing API boundaries - not
for logic on either side.

https://codereview.chromium.org/11280255/diff/2001/webkit/glue/fling_animator...
webkit/glue/fling_animator_impl_android.h:35: const WebKit::WebRect& range);
indentation - this should be aligned with the opening "(" if it doesn't fit on
the same line

[rjkroege, 2012-12-03 16:55:09]

ptal

https://codereview.chromium.org/11280255/diff/2001/webkit/glue/fling_animator...
File webkit/glue/fling_animator_impl_android.h (right):

https://codereview.chromium.org/11280255/diff/2001/webkit/glue/fling_animator...
webkit/glue/fling_animator_impl_android.h:34: void startFling(const
WebKit::WebFloatPoint& velocity,
On 2012/12/01 01:47:19, jamesr wrote:
> if this isn't implementing exposed API and is just a chromium implementation,
it
> should be using gfx:: geometry types. I think you want gfx::PointF and
gfx::Rect
> here.
> 
> WebKit:: geometry types should be used only for crossing API boundaries - not
> for logic on either side.

Done. And an assortment of other minor style nits.

https://codereview.chromium.org/11280255/diff/2001/webkit/glue/fling_animator...
webkit/glue/fling_animator_impl_android.h:35: const WebKit::WebRect& range);
On 2012/12/01 01:47:19, jamesr wrote:
> indentation - this should be aligned with the opening "(" if it doesn't fit on
> the same line

Done.

[jamesr, 2012-12-03 17:41:18]

lgtm

[commit-bot: I haz the power, 2012-12-03 17:51:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjkroege@chromium.org/11280255/9001

[commit-bot: I haz the power, 2012-12-03 18:47:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rjkroege@chromium.org/11280255/9001

[commit-bot: I haz the power, 2012-12-04 01:16:13]

Change committed as 170857