Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/resources/shared/js/cr/ui/table/table_header.js

Issue 11280253: Fixing column widths in tables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review fixes. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/shared/js/cr/ui/table/table_header.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/table/table_header.js b/chrome/browser/resources/shared/js/cr/ui/table/table_header.js
index 82438feb7dc99f195a81e8a76e364ef5d92ae9cf..f48eb5e3a44a1508001ac50461d528d3b9c9d54b 100644
--- a/chrome/browser/resources/shared/js/cr/ui/table/table_header.js
+++ b/chrome/browser/resources/shared/js/cr/ui/table/table_header.js
@@ -58,7 +58,7 @@ cr.define('cr.ui.table', function() {
}
for (var i = 0; i < cm.size; i++) {
- headerCells[i].style.width = cm.getWidth(i) + '%';
+ headerCells[i].style.width = cm.getWidth(i) + 'px';
}
this.placeSplitters_(this.querySelectorAll('.table-header-splitter'));
},
@@ -94,7 +94,7 @@ cr.define('cr.ui.table', function() {
for (var i = 0; i < cm.size; i++) {
var cell = this.ownerDocument.createElement('div');
- cell.style.width = cm.getWidth(i) + '%';
+ cell.style.width = cm.getWidth(i) + 'px';
cell.className = 'table-header-cell';
if (dm.isSortable(cm.getId(i)))
cell.addEventListener('click',
@@ -112,7 +112,7 @@ cr.define('cr.ui.table', function() {
appendSplitters_: function() {
var cm = this.table_.columnModel;
var splitters = [];
- for (var i = 0; i < cm.size - 1; i++) {
+ for (var i = 0; i < cm.size; i++) {
// splitter should use CSS for background image.
var splitter = new TableSplitter({table: this.table_});
splitter.columnIndex = i;
@@ -130,14 +130,11 @@ cr.define('cr.ui.table', function() {
* @param {Array.<HTMLElement>|NodeList} splitters Array of splitters.
*/
placeSplitters_: function(splitters) {
- var rtl = this.ownerDocument.defaultView.getComputedStyle(this).
- direction == 'rtl';
var cm = this.table_.columnModel;
- var leftPercent = 0;
- for (var i = 0; i < cm.size - 1; i++) {
- leftPercent += cm.getWidth(i);
- splitters[i].style.left = rtl ? 100 - leftPercent + '%' :
- leftPercent + '%';
+ var place = 0;
+ for (var i = 0; i < cm.size; i++) {
+ place += cm.getWidth(i);
+ splitters[i].style.webkitMarginStart = place + 'px';
}
},

Powered by Google App Engine
This is Rietveld 408576698