Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1842)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java

Issue 11280250: Add waitUntilHasValue() to simplify usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase.. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java b/android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java
index 09264bca0029ea4b59cc8da1c7af6e7f850e052d..96455177a0bf809a781752e0494b26f872f434d4 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java
@@ -61,7 +61,6 @@ public class JSUtils {
final AwContents awContents,
final OnEvaluateJavaScriptResultHelper onEvaluateJavaScriptResultHelper,
final String code) throws Throwable {
- int currentCallCount = onEvaluateJavaScriptResultHelper.getCallCount();
testCase.getInstrumentation().runOnMainSync(new Runnable() {
@Override
public void run() {
@@ -69,7 +68,7 @@ public class JSUtils {
awContents.getContentViewCore(), code);
}
});
- onEvaluateJavaScriptResultHelper.waitForCallback(currentCallCount);
+ onEvaluateJavaScriptResultHelper.waitUntilHasValue();
Assert.assertTrue("Failed to retrieve JavaScript evaluation results.",
onEvaluateJavaScriptResultHelper.hasValue());
return onEvaluateJavaScriptResultHelper.getJsonResultAndClear();
« no previous file with comments | « no previous file | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698