Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 11280240: Add additional profile shortcut manager tests. (Closed)

Created:
8 years ago by Alexei Svitkine (slow)
Modified:
8 years ago
Reviewers:
sail
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Add additional profile shortcut manager tests. Adds a test for CreateProfileShortcutFlags() and another test for when a second profile is created without shortcut, which verifies the first profile's icon got renamed and badged (via icon). Also, refactors RenameProfile() to a helper function and makes ValidateProfileShortcutAtPath() check the icon that was set on the shortcut. BUG=none TEST=this adds some Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170408

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -17 lines) Patch
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 5 chunks +49 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
8 years ago (2012-11-29 20:46:02 UTC) #1
sail
LGTM!
8 years ago (2012-11-29 20:56:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11280240/1004
8 years ago (2012-11-29 21:24:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests, chrome_frame_unittests, content_browsertests, installer_util_unittests, mini_installer_test, nacl_integration, ...
8 years ago (2012-11-30 01:25:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11280240/1004
8 years ago (2012-11-30 04:02:17 UTC) #5
commit-bot: I haz the power
8 years ago (2012-11-30 05:35:57 UTC) #6
Message was sent while issue was closed.
Change committed as 170408

Powered by Google App Engine
This is Rietveld 408576698