Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 11280239: Subclassable TestCallbackHelperContainer constructor for tests. (Closed)

Created:
8 years ago by aruslan
Modified:
8 years ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Subclassable TestCallbackHelperContainer constructor for tests. BUG=161941 TEST=No visible functionality changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aruslan
Please review and apply the OWNERS seal as appropriate.
8 years ago (2012-11-29 18:43:01 UTC) #1
Jay Civelli
lgtm
8 years ago (2012-11-29 18:47:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/11280239/1
8 years ago (2012-11-29 19:08:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
8 years ago (2012-11-29 20:51:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/11280239/1
8 years ago (2012-11-29 20:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/11280239/1
8 years ago (2012-11-30 02:24:56 UTC) #6
commit-bot: I haz the power
8 years ago (2012-11-30 15:42:18 UTC) #7
Message was sent while issue was closed.
Change committed as 170455

Powered by Google App Engine
This is Rietveld 408576698