Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11280236: A11y: Add the option to always show the a11y tray menu regardless of the state of a11y features (Closed)

Created:
8 years ago by yoshiki
Modified:
8 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

A11y: Add the option to always show the a11y tray menu regardless of the state of a11y features Change summary: - Add 'const' to ShellDelegate::IsUserLoggedIn() - Use TrayImageItem::UpdateAfterLoginStatusChange delegate instead of ShellObserver::OnLoginStateChanged() - Add a pref: kShouldAlwaysShowAccessibilityMenu - Add a checkbox to chrome://settings BUG=158287 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170732

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fix (#2 & #5) #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -39 lines) Patch
M ash/shell/shell_delegate_impl.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ash/shell_delegate.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/tray_accessibility.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/system/tray_accessibility.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 5 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yoshiki
Could you take a look? Thanks, @derat - ash/* - chrome/browser/ui/ash/* @stevenjb - ash/system/* - ...
8 years ago (2012-11-29 15:50:59 UTC) #1
stevenjb
https://codereview.chromium.org/11280236/diff/1/ash/shell/shell_delegate_impl.h File ash/shell/shell_delegate_impl.h (right): https://codereview.chromium.org/11280236/diff/1/ash/shell/shell_delegate_impl.h#newcode27 ash/shell/shell_delegate_impl.h:27: virtual bool CanLockScreen() OVERRIDE; While you're in here can ...
8 years ago (2012-11-29 18:07:01 UTC) #2
stevenjb
(otherwise ash/chromeos lgtm)
8 years ago (2012-11-29 18:07:21 UTC) #3
Daniel Erat
lgtm
8 years ago (2012-11-29 20:32:04 UTC) #4
James Hawkins
LGTM with nit. https://codereview.chromium.org/11280236/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/11280236/diff/1/chrome/browser/resources/options/browser_options.html#newcode607 chrome/browser/resources/options/browser_options.html:607: pref="settings.a11y.always_show_menu" nit: Wrapped lines should be ...
8 years ago (2012-11-29 20:34:54 UTC) #5
yoshiki
Thanks! https://codereview.chromium.org/11280236/diff/1/ash/shell/shell_delegate_impl.h File ash/shell/shell_delegate_impl.h (right): https://codereview.chromium.org/11280236/diff/1/ash/shell/shell_delegate_impl.h#newcode27 ash/shell/shell_delegate_impl.h:27: virtual bool CanLockScreen() OVERRIDE; On 2012/11/29 18:07:01, stevenjb ...
8 years ago (2012-11-30 14:55:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11280236/6001
8 years ago (2012-11-30 15:37:36 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-11-30 18:17:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11280236/6001
8 years ago (2012-12-03 01:47:50 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-03 04:39:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11280236/12004
8 years ago (2012-12-03 08:46:31 UTC) #11
commit-bot: I haz the power
8 years ago (2012-12-03 14:22:58 UTC) #12
Message was sent while issue was closed. 
Change committed as 170732

Powered by Google App Engine
This is Rietveld 408576698