Move RenderStats enumeration out of gpu_benchmarking_extension.

Move RenderStats enumeration out of gpu_benchmarking_extension.

With this patch, we won't have to keep modifying gpu_benchmarking_extension when
we add new fields to RenderStats.

BUG=163073
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170474

[hartmanng, 2012-11-28 15:13:20]

Please take a look.

nduca for cc/ OWNERS and general approach
piman for content/ OWNERS

Thanks!

[nduca, 2012-11-28 21:27:35]

lgtm

https://codereview.chromium.org/11280210/diff/2001/cc/rendering_stats.h
File cc/rendering_stats.h (left):

https://codereview.chromium.org/11280210/diff/2001/cc/rendering_stats.h#oldco...
cc/rendering_stats.h:26: int64 numLayersInLayerTree;
Put a comment up here that reminds folks who add fields to update
enumerateFields?

https://codereview.chromium.org/11280210/diff/2001/content/renderer/gpu/gpu_b...
File content/renderer/gpu/gpu_benchmarking_extension.cc (left):

https://codereview.chromium.org/11280210/diff/2001/content/renderer/gpu/gpu_b...
content/renderer/gpu/gpu_benchmarking_extension.cc:198:
stats_object->Set(v8::String::New("globalTextureUploadCount"),
can we do this for the gpu stats too, as a followup or part of this?

[piman, 2012-11-28 22:46:52]

lgtm

[hartmanng, 2012-11-28 23:18:17]

PTAL for the gpu_rendering_stats side.

https://codereview.chromium.org/11280210/diff/2001/cc/rendering_stats.h
File cc/rendering_stats.h (left):

https://codereview.chromium.org/11280210/diff/2001/cc/rendering_stats.h#oldco...
cc/rendering_stats.h:26: int64 numLayersInLayerTree;
On 2012/11/28 21:27:35, nduca wrote:
> Put a comment up here that reminds folks who add fields to update
> enumerateFields?

Done.

https://codereview.chromium.org/11280210/diff/2001/content/renderer/gpu/gpu_b...
File content/renderer/gpu/gpu_benchmarking_extension.cc (left):

https://codereview.chromium.org/11280210/diff/2001/content/renderer/gpu/gpu_b...
content/renderer/gpu/gpu_benchmarking_extension.cc:198:
stats_object->Set(v8::String::New("globalTextureUploadCount"),
On 2012/11/28 21:27:35, nduca wrote:
> can we do this for the gpu stats too, as a followup or part of this?

Done.

[piman, 2012-11-28 23:23:17]

LGTM+nit. Note, if the enumerator interfaces are going to grow / overlap it may
make sense to merge them.

https://codereview.chromium.org/11280210/diff/6003/content/common/gpu/gpu_ren...
File content/common/gpu/gpu_rendering_stats.h (right):

https://codereview.chromium.org/11280210/diff/6003/content/common/gpu/gpu_ren...
content/common/gpu/gpu_rendering_stats.h:32: virtual void addInt(const char*
name, int value) = 0;
nit: chrome style for function names

[hartmanng, 2012-11-29 15:16:08]

On 2012/11/28 23:23:17, piman wrote:
> LGTM+nit. Note, if the enumerator interfaces are going to grow / overlap it
may
> make sense to merge them.
> 

Good point, I uploaded a patch to merge the enumerators. I've made changes in
both content/ and cc/ code for this patch, so probably best to get a final look
over from both of you (sorry, hopefully the last one).

PTAL.

[piman, 2012-11-29 17:16:32]

LGTM, great!

[nduca, 2012-11-29 21:55:18]

lgtm

[commit-bot: I haz the power, 2012-11-29 22:04:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11280210/2004

[commit-bot: I haz the power, 2012-11-29 23:24:49]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-30 15:37:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11280210/9008

[commit-bot: I haz the power, 2012-11-30 17:34:24]

Change committed as 170474