Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 11280205: Add the ability for tests to have more than one name. (Closed)

Created:
8 years ago by iannucci
Modified:
8 years ago
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Base URL:
http://git.chromium.org/chromium/tools/build.git@neuter
Visibility:
Public.

Description

Add the ability for tests to have more than one name. This will allow us to transition towards unit test names which match their build target names exactly. This change includes some aliases to get things started. R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=170232

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M scripts/master/factory/chromium_factory.py View 7 chunks +16 lines, -15 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
iannucci
Cut out of https://chromiumcodereview.appspot.com/11379003/
8 years ago (2012-11-28 03:20:37 UTC) #1
M-A Ruel
+Mike for the _br stuff. https://chromiumcodereview.appspot.com/11280205/diff/1/scripts/master/factory/chromium_factory.py File scripts/master/factory/chromium_factory.py (right): https://chromiumcodereview.appspot.com/11280205/diff/1/scripts/master/factory/chromium_factory.py#newcode422 scripts/master/factory/chromium_factory.py:422: if R('unit_br'): These ones ...
8 years ago (2012-11-28 14:05:42 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/11280205/diff/1/scripts/master/factory/chromium_factory.py File scripts/master/factory/chromium_factory.py (right): https://chromiumcodereview.appspot.com/11280205/diff/1/scripts/master/factory/chromium_factory.py#newcode422 scripts/master/factory/chromium_factory.py:422: if R('unit_br'): On 2012/11/28 14:05:42, Marc-Antoine Ruel wrote: > ...
8 years ago (2012-11-28 19:17:11 UTC) #3
M-A Ruel
lgtm anyhow. Please discuss with Mike with the plan going forward.
8 years ago (2012-11-28 20:14:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/11280205/1
8 years ago (2012-11-29 19:02:36 UTC) #5
commit-bot: I haz the power
8 years ago (2012-11-29 19:04:06 UTC) #6
Message was sent while issue was closed.
Change committed as 170232

Powered by Google App Engine
This is Rietveld 408576698