Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11280159: Remove ibus dependency from PanelService. (Closed)

Created:
8 years ago by Seigo Nonaka
Modified:
8 years ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove ibus dependency from PanelService. This is the last CL for libibus removal. We can also remove InputMethodLookupTable and IBusUiController as well, but let me split cl for them. BUG=158264, 158265 TEST=Manually done on lumpy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170790

Patch Set 1 : #

Patch Set 2 : #

Total comments: 17

Patch Set 3 : Address comment #

Total comments: 6

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -1099 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window_controller.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.h View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 2 4 chunks +15 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 1 5 chunks +8 lines, -52 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 2 3 12 chunks +55 lines, -322 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_ui_controller.h View 1 2 3 5 chunks +35 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_ui_controller.cc View 1 2 3 4 chunks +156 lines, -661 lines 0 comments Download
D chrome/browser/chromeos/input_method/ibus_ui_controller_unittest.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Seigo Nonaka
8 years ago (2012-11-29 13:32:19 UTC) #1
satorux1
looks awesome. just minor nits: https://codereview.chromium.org/11280159/diff/8002/chrome/browser/chromeos/input_method/candidate_window_controller.cc File chrome/browser/chromeos/input_method/candidate_window_controller.cc (right): https://codereview.chromium.org/11280159/diff/8002/chrome/browser/chromeos/input_method/candidate_window_controller.cc#newcode19 chrome/browser/chromeos/input_method/candidate_window_controller.cc:19: // TODO(nona): Refine observer ...
8 years ago (2012-11-30 05:37:34 UTC) #2
Seigo Nonaka
https://codereview.chromium.org/11280159/diff/8002/chrome/browser/chromeos/input_method/candidate_window_controller.cc File chrome/browser/chromeos/input_method/candidate_window_controller.cc (right): https://codereview.chromium.org/11280159/diff/8002/chrome/browser/chromeos/input_method/candidate_window_controller.cc#newcode19 chrome/browser/chromeos/input_method/candidate_window_controller.cc:19: // TODO(nona): Refine observer chain after remove IBusUiController. On ...
8 years ago (2012-12-01 16:22:42 UTC) #3
satorux1
LGTM with nits https://codereview.chromium.org/11280159/diff/4015/chrome/browser/chromeos/input_method/ibus_controller_impl.cc File chrome/browser/chromeos/input_method/ibus_controller_impl.cc (right): https://codereview.chromium.org/11280159/diff/4015/chrome/browser/chromeos/input_method/ibus_controller_impl.cc#newcode598 chrome/browser/chromeos/input_method/ibus_controller_impl.cc:598: // Restores previous input method at ...
8 years ago (2012-12-02 23:14:24 UTC) #4
Seigo Nonaka
Thank you for your review! https://codereview.chromium.org/11280159/diff/4015/chrome/browser/chromeos/input_method/ibus_controller_impl.cc File chrome/browser/chromeos/input_method/ibus_controller_impl.cc (right): https://codereview.chromium.org/11280159/diff/4015/chrome/browser/chromeos/input_method/ibus_controller_impl.cc#newcode598 chrome/browser/chromeos/input_method/ibus_controller_impl.cc:598: // Restores previous input ...
8 years ago (2012-12-03 09:53:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11280159/2033
8 years ago (2012-12-03 09:53:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-03 13:32:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11280159/2033
8 years ago (2012-12-03 15:15:54 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 15:59:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11280159/2033
8 years ago (2012-12-03 16:12:35 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 17:06:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11280159/2033
8 years ago (2012-12-03 18:09:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11280159/2033
8 years ago (2012-12-03 18:46:18 UTC) #13
commit-bot: I haz the power
8 years ago (2012-12-03 19:29:03 UTC) #14
Message was sent while issue was closed. 
Change committed as 170790

Powered by Google App Engine
This is Rietveld 408576698