Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11280140: Pass calls to GetApplicationInfo through the scheduler (Closed)

Created:
8 years, 1 month ago by Zachary Kuznia
Modified:
8 years ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Pass calls to GetApplicationInfo through the scheduler BUG=160904 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170913

Patch Set 1 #

Patch Set 2 : Code review #

Patch Set 3 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -4 lines) Patch
M chrome/browser/chromeos/drive/drive_feed_loader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler.h View 1 2 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler.cc View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler_unittest.cc View 1 2 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Zachary Kuznia
8 years, 1 month ago (2012-11-22 07:28:54 UTC) #1
kinaba
Just like https://codereview.chromium.org/11418127/, you might want to move away from MockDriveService. Otherwise looking good.
8 years ago (2012-11-27 00:56:51 UTC) #2
Zachary Kuznia
On 2012/11/27 00:56:51, kinaba wrote: > Just like https://codereview.chromium.org/11418127/, you might want to move away ...
8 years ago (2012-12-03 09:28:05 UTC) #3
kinaba
lgtm, thanks,
8 years ago (2012-12-03 11:09:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/11280140/2002
8 years ago (2012-12-04 01:31:50 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 04:25:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/11280140/2002
8 years ago (2012-12-04 04:26:37 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 06:47:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/11280140/2002
8 years ago (2012-12-04 06:59:10 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-04 09:40:31 UTC) #10
Message was sent while issue was closed. 
Change committed as 170913

Powered by Google App Engine
This is Rietveld 408576698