Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 11280115: Remove PrefObserver usages, batch 12. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix removal of PrefServiceObserver usage. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index e6b893d0ae9cd9160b30f060e1f59336e7ad53a5..c3f4d37e16ca6cee1b93522eb2bc6c4f434f4768 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -89,7 +89,10 @@ BrowserWindowCocoa::BrowserWindowCocoa(Browser* browser,
attention_request_id_(0) {
pref_change_registrar_.Init(browser_->profile()->GetPrefs());
- pref_change_registrar_.Add(prefs::kShowBookmarkBar, this);
+ pref_change_registrar_.Add(
+ prefs::kShowBookmarkBar,
+ base::Bind(&BrowserWindowCocoa::OnShowBookmarkBarChanged,
+ base::Unretained(this)));
gfx::Rect bounds;
chrome::GetSavedWindowBoundsAndShowState(browser_,
&bounds,
@@ -614,9 +617,7 @@ bool BrowserWindowCocoa::GetConstrainedWindowTopY(int* top_y) {
return false;
}
-void BrowserWindowCocoa::OnPreferenceChanged(PrefServiceBase* service,
- const std::string& pref_name) {
- DCHECK(pref_name == prefs::kShowBookmarkBar);
+void BrowserWindowCocoa::OnShowBookmarkBarChanged() {
[controller_ updateBookmarkBarVisibilityWithAnimation:YES];
}
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698