Initialize compositor early on.

Initialize compositor early on so the rest of the code can assumed it is
already initialized.

BUG=162312
TEST=Chrome, content shell and test shell should still work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169716

[Jay Civelli, 2012-11-21 18:16:15]

Daniel, per our discussion, moved the Compositor initialization to
ChromeBrowserMainPartsAndroid.
It is executed once for the browser process only, for Chrome and
ChromiumTestShell.

[Ted C, 2012-11-21 18:17:34]

lgtm

[no sievers, 2012-11-21 18:22:30]

lgtm

[commit-bot: I haz the power, 2012-11-21 19:44:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11280097/8001

[commit-bot: I haz the power, 2012-11-21 19:44:39]

Presubmit check for 11280097-8001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.1s to calculate.

[Jay Civelli, 2012-11-21 19:51:01]

Scott,
Could you take a look, I need an chrome OWNER approval.

Thanks!

Jay

[Jay Civelli, 2012-11-21 21:09:09]

Hey Nico,
Could you take a look if you have a chance?
I need a chrome/ OWNERS approval.

Thanks.

Jay

[Nico, 2012-11-21 21:28:22]

Either add a bug line linking to a bug, or describe "why?" in the cl description

[Jay Civelli, 2012-11-21 21:38:55]

On 2012/11/21 21:28:22, Nico wrote:
> Either add a bug line linking to a bug, or describe "why?" in the cl
description

Added a bug.

[Nico, 2012-11-21 22:14:59]

From the bug, it sounds like this change is done to fix an assert. Is it
possible to write a regression test for this? (I don't know how the
chrome/android test suite works, so not sure if that's doable.)

[Jay Civelli, 2012-11-26 19:05:28]

On 2012/11/21 22:14:59, Nico wrote:
> From the bug, it sounds like this change is done to fix an assert. Is it
> possible to write a regression test for this? (I don't know how the
> chrome/android test suite works, so not sure if that's doable.)

Added a test.

[sky, 2012-11-26 22:00:20]

LGTM

[Nico, 2012-11-26 22:03:45]

Patch set 5 lgtm, thanks. It'd be cool if one of the android peeps (ted c
mayhaps) could take a quick look at the shiny new test.

[Ted C, 2012-11-26 22:06:24]

lgtm for the shiny android test

[commit-bot: I haz the power, 2012-11-26 23:15:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11280097/7006

[commit-bot: I haz the power, 2012-11-27 00:37:10]

Retried try job too often for step(s) check_deps

[Jay Civelli, 2012-11-27 17:14:03]

Ted, I had to update the DEPS.
Let me know if this still looks good.

Thanks.

Jay

[Ted C, 2012-11-27 17:34:18]

lgtm -- deps inclusion looks entirely reasonable to me

[commit-bot: I haz the power, 2012-11-27 17:37:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11280097/15002

[commit-bot: I haz the power, 2012-11-27 20:18:45]

Change committed as 169716