Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 11280073: Allow multiple object proxies to handle NameOwnerChanged (Closed)

Created:
8 years, 1 month ago by keybuk
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Allow multiple object proxies to handle NameOwnerChanged Multiple object proxies may be registered for any single D-Bus service, one per interface. Returning "handled" means only the first interface object proxy gets to handle the signal, others never see it. Change to always return "not yet handled", while this means D-Bus never knows we actually handled the NameOwnerChanged signal, that's quite ok and is actually what all other bindings do for all signals. Submitted as -r169164 but reverted in -r169170; resubmitted with change to run message loop three times if necessary. BUG=chromium-os:36486 TEST=dbus_unittests TBR=gauravsh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -7 lines) Patch
M dbus/object_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 4 chunks +76 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
keybuk
8 years, 1 month ago (2012-11-19 23:14:45 UTC) #1
keybuk
8 years, 1 month ago (2012-11-19 23:42:43 UTC) #2
gauravsh
lgtm from me - I have tested the fix and it does resolve crosbug.com/34399 in ...
8 years, 1 month ago (2012-11-20 00:02:10 UTC) #3
mukesh agrawal
lgtm from here, as well. On Mon, Nov 19, 2012 at 4:02 PM, <gauravsh@chromium.org> wrote: ...
8 years, 1 month ago (2012-11-20 00:11:55 UTC) #4
Haruki Sato
lgtm Thank you for the quick fix! On 2012/11/20 00:11:55, mukesh agrawal wrote: > lgtm ...
8 years, 1 month ago (2012-11-20 01:31:22 UTC) #5
satorux1
LGTM
8 years, 1 month ago (2012-11-20 05:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/11280073/1
8 years, 1 month ago (2012-11-21 21:42:08 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-21 23:44:43 UTC) #8
Change committed as 169164

Powered by Google App Engine
This is Rietveld 408576698