Fixed TopSitesTest.Blacklisting issue for Android

Fixed TopSitesTest.Blacklisting issue for Android

BUG=146857
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170218

[Yaron, 2012-11-19 23:23:57]

Can you repeat it 10-20 times. It was markes as flaky which means it won't
necessarily fail on one go

[michaelbai, 2012-11-27 17:47:46]

Reproduced it by running 30+ times, here is the fix, ran 100 times, there was no
crash with this patch.

[sky, 2012-11-27 18:07:01]

https://codereview.chromium.org/11280070/diff/6001/chrome/browser/history/top...
File chrome/browser/history/top_sites_unittest.cc (right):

https://codereview.chromium.org/11280070/diff/6001/chrome/browser/history/top...
chrome/browser/history/top_sites_unittest.cc:1156:
EXPECT_NE(prepopulate_url.spec(), q.urls()[2].url.spec());
Can you add an else case that does:
EXPECT_EQ(1u, GetPropopulatePates().size());

[Yaron, 2012-11-27 18:07:50]

lgtm with sky's approval

[michaelbai, 2012-11-27 20:07:06]

PTAL

https://codereview.chromium.org/11280070/diff/6001/chrome/browser/history/top...
File chrome/browser/history/top_sites_unittest.cc (right):

https://codereview.chromium.org/11280070/diff/6001/chrome/browser/history/top...
chrome/browser/history/top_sites_unittest.cc:1156:
EXPECT_NE(prepopulate_url.spec(), q.urls()[2].url.spec());
On 2012/11/27 18:07:01, sky wrote:
> Can you add an else case that does:
> EXPECT_EQ(1u, GetPropopulatePates().size());

Done.

[sky, 2012-11-27 21:43:17]

LGTM

[commit-bot: I haz the power, 2012-11-27 21:57:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11280070/10001

[commit-bot: I haz the power, 2012-11-27 21:57:41]

Presubmit check for 11280070-10001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Add a description.

[commit-bot: I haz the power, 2012-11-27 22:03:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11280070/10001

[commit-bot: I haz the power, 2012-11-28 00:49:28]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-29 04:39:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11280070/13002

[commit-bot: I haz the power, 2012-11-29 05:08:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-29 16:24:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11280070/13002

[commit-bot: I haz the power, 2012-11-29 17:33:34]

Change committed as 170218