Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/installer/util/google_chrome_distribution.h

Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: grt additional comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file extends generic BrowserDistribution class to declare Google Chrome 5 // This file extends generic BrowserDistribution class to declare Google Chrome
6 // specific implementation. 6 // specific implementation.
7 7
8 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_CHROME_DISTRIBUTION_H_ 8 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_CHROME_DISTRIBUTION_H_
9 #define CHROME_INSTALLER_UTIL_GOOGLE_CHROME_DISTRIBUTION_H_ 9 #define CHROME_INSTALLER_UTIL_GOOGLE_CHROME_DISTRIBUTION_H_
10 10
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 // Assuming that the user qualifies, this function performs the inactive user 99 // Assuming that the user qualifies, this function performs the inactive user
100 // toast experiment. It will use chrome to show the UI and it will record the 100 // toast experiment. It will use chrome to show the UI and it will record the
101 // outcome in the registry. 101 // outcome in the registry.
102 virtual void InactiveUserToastExperiment( 102 virtual void InactiveUserToastExperiment(
103 int flavor, 103 int flavor,
104 const string16& experiment_group, 104 const string16& experiment_group,
105 const installer::Product& installation, 105 const installer::Product& installation,
106 const FilePath& application_path) OVERRIDE; 106 const FilePath& application_path) OVERRIDE;
107 107
108 virtual bool ShouldSetExperimentLabels() OVERRIDE;
109
108 const string16& product_guid() { return product_guid_; } 110 const string16& product_guid() { return product_guid_; }
109 111
110 protected: 112 protected:
111 void set_product_guid(const string16& guid) { product_guid_ = guid; } 113 void set_product_guid(const string16& guid) { product_guid_ = guid; }
112 114
113 // Disallow construction from others. 115 // Disallow construction from others.
114 GoogleChromeDistribution(); 116 GoogleChromeDistribution();
115 117
116 private: 118 private:
117 friend class BrowserDistribution; 119 friend class BrowserDistribution;
(...skipping 17 matching lines...) Expand all
135 // Returns true if at least one uninstall metric was found in 137 // Returns true if at least one uninstall metric was found in
136 // uninstall_metrics_dict, false otherwise. 138 // uninstall_metrics_dict, false otherwise.
137 virtual bool BuildUninstallMetricsString( 139 virtual bool BuildUninstallMetricsString(
138 const base::DictionaryValue* uninstall_metrics_dict, string16* metrics); 140 const base::DictionaryValue* uninstall_metrics_dict, string16* metrics);
139 141
140 // The product ID for Google Update. 142 // The product ID for Google Update.
141 string16 product_guid_; 143 string16 product_guid_;
142 }; 144 };
143 145
144 #endif // CHROME_INSTALLER_UTIL_GOOGLE_CHROME_DISTRIBUTION_H_ 146 #endif // CHROME_INSTALLER_UTIL_GOOGLE_CHROME_DISTRIBUTION_H_
OLDNEW
« no previous file with comments | « chrome/installer/util/browser_distribution.cc ('k') | chrome/installer/util/google_chrome_distribution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698