Issue 11280064: Android WebView save/restoreState Part 2

Issue 11280064: Android WebView save/restoreState Part 2 (Closed)

Created:
8 years, 1 month ago by boliu

Modified:
8 years, 1 month ago

Reviewers:
joth, mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android WebView save/restoreState Part 2 This contains plumbing Java calls to native side and java integration tests. Contains some java test refactoring. BUG= Android only change. Ran through Android trybots NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169059

Patch Set 1 #

Patch Set 2 : PS1 contains Part 1 for tryjobs. Review this instead. #

Patch Set 3 : Add test annotations. Contains part 1 for tryjob. Do not review. #

Patch Set 4 : Same as previous but no Part 1. #

Patch Set 5 : Fix typo in comments. #

Total comments: 3

Patch Set 6 : rename variable #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+276 lines, -31 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContents.java	View	1 2 3 4 5	2 chunks	+47 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java	View	1 2 3 4	2 chunks	+30 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java	View		1 chunk	+0 lines, -10 lines	0 comments	Download
A	android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java	View	1 2 3 4 5	1 chunk	+166 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java	View		3 chunks	+1 line, -21 lines	0 comments	Download
M	android_webview/native/aw_contents.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	android_webview/native/aw_contents.cc	View	1 2 3 4	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

joth

lgtm https://codereview.chromium.org/11280064/diff/10001/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/11280064/diff/10001/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode632 android_webview/java/src/org/chromium/android_webview/AwContents.java:632: public static final String STATE_KEY = "WEBVIEW_CHROMIUM_STATE"; suggest ...

8 years, 1 month ago (2012-11-21 00:56:14 UTC) #3

boliu

https://codereview.chromium.org/11280064/diff/10001/android_webview/native/aw_contents.cc File android_webview/native/aw_contents.cc (right): https://codereview.chromium.org/11280064/diff/10001/android_webview/native/aw_contents.cc#newcode476 android_webview/native/aw_contents.cc:476: // problem. On 2012/11/21 00:56:14, joth wrote: > yeah ...

8 years, 1 month ago (2012-11-21 01:22:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/11280064/6008

8 years, 1 month ago (2012-11-21 16:22:57 UTC) #6

Change committed as 169059

Expand Messages | Collapse Messages