Chromium Code Reviews
Help | Chromium Project | Sign in
(6)

Issue 11280054: Ensure CopyElementsImpl is always executed so it fills in holes even if from_size is 0. Allow Fixed… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Toon Verwaest
Modified:
1 year, 5 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Ensure CopyElementsImpl is always executed so it fills in holes even if from_size is 0. Allow FixedDoubleArray::cast to also support FixedArray with size 0.

Committed: https://code.google.com/p/v8/source/detail?r=13000

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added castOrEmptyFixedArray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Lint Patch
M src/elements.cc View 1 4 chunks +10 lines, -12 lines 0 comments ? errors Download
M src/objects.h View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
M src/objects-inl.h View 1 1 chunk +7 lines, -0 lines 0 comments ? errors Download
M test/mjsunit/array-store-and-grow.js View 1 chunk +4 lines, -1 line 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 4
Toon Verwaest
PTAL
1 year, 5 months ago #1
danno
lgtm
1 year, 5 months ago #2
Michael Starzinger (Google)
Drive-by-comments. https://chromiumcodereview.appspot.com/11280054/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/11280054/diff/1/src/objects-inl.h#newcode2345 src/objects-inl.h:2345: FixedDoubleArray* FixedDoubleArray::cast(Object* object) { As discussed offline, I ...
1 year, 5 months ago #3
Toon Verwaest
1 year, 5 months ago #4
addressed comments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6