Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 11280030: Implement the ability to obliterate a storage partition from disk. (Closed)

Created:
8 years, 1 month ago by Charlie Reis
Modified:
8 years, 1 month ago
Reviewers:
Matt Perry
CC:
chromium-reviews, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, jam, chromium-apps-reviews_chromium.org, nasko, awong
Visibility:
Public.

Description

Implement the ability to obliterate a storage partition from disk. On the uninstall of an extension with isolated storage, we want to delete all the data for the extension from disk as soon as possible. Because we cannot know when various objects with state on disk (eg., FileSystemContext) have all been deleted, we do a best-effort delete for any directory that we know isn't being used. The way this gets projected into the content modulue is that each extension defines one partition_domain. If an extension has a <webview> tag, it will also have multiple StoragePartitions, each with a different partition_name. If it doesn't have a <webview> tag, the partition_name is considered empty which yields the default partition. The default partition, and all webview partitions are peers inside the partition_domain's root directory. This CL introduces a function that allows us to delete partiton domain. Special care is taken to not accidentally instantiate a StoragePartition for the domain if none current exists. This is necessary to allow us to actually delete the whole partition domain directory. (Patch by ajwong@chromium.org) BUG=85127 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -81 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +40 lines, -19 lines 0 comments Download
M chrome/browser/extensions/data_deleter.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/browser_context.cc View 5 chunks +22 lines, -7 lines 0 comments Download
M content/browser/storage_partition_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 4 chunks +85 lines, -35 lines 0 comments Download
M content/browser/storage_partition_impl_map.h View 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/storage_partition_impl_map.cc View 7 chunks +155 lines, -8 lines 0 comments Download
M content/public/browser/browser_context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +13 lines, -5 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/storage_partition.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Matt, can you repeat your review on this copy? It's the same as https://chromiumcodereview.appspot.com/11362268/ with ...
8 years, 1 month ago (2012-11-16 20:11:16 UTC) #1
Matt Perry
lgtm
8 years, 1 month ago (2012-11-16 20:15:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/11280030/1
8 years, 1 month ago (2012-11-16 20:18:08 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-17 12:20:12 UTC) #4
Change committed as 168405

Powered by Google App Engine
This is Rietveld 408576698