Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 11280007: Fixed shutdown of LoginUtilsTest. (Closed)

Created:
8 years, 1 month ago by Joao da Silva
Modified:
8 years, 1 month ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Wez
Visibility:
Public.

Description

Fixed shutdown of LoginUtilsTest. The shutdown of ProfileIOData started triggering a DCHECK on chrome_http_user_agent_settings.cc. Fixed this and similar issues by having a fake IO loop always available during the test. This is a reland of https://codereview.chromium.org/11358160/ after fixing the Thread crash at shutdown on debug builds. BUG=158839 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167915

Patch Set 1 #

Patch Set 2 : Fix for the previous CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -24 lines) Patch
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 7 chunks +88 lines, -24 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
Relanding after fixing the crash on debug builds (see delta from patch set 2 to ...
8 years, 1 month ago (2012-11-15 11:38:05 UTC) #1
Nikita (slow)
lgtm
8 years, 1 month ago (2012-11-15 11:47:58 UTC) #2
Nikita (slow)
I prefer reusing existing codereview for relanding changes.
8 years, 1 month ago (2012-11-15 11:48:37 UTC) #3
jochen (gone - plz use gerrit)
lgtm
8 years, 1 month ago (2012-11-15 11:58:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/11280007/2001
8 years, 1 month ago (2012-11-15 13:26:11 UTC) #5
commit-bot: I haz the power
Change committed as 167915
8 years, 1 month ago (2012-11-15 14:27:39 UTC) #6
Wez
8 years, 1 month ago (2012-11-15 17:25:09 UTC) #7
Please don't re-land twice from the same code review; see the thread on
chromium-dev@ on the subject. :)
On 15 Nov 2012 03:48, <nkostylev@chromium.org> wrote:

> I prefer reusing existing codereview for relanding changes.
>
>
https://codereview.chromium.**org/11280007/<https://codereview.chromium.org/1...
>

Powered by Google App Engine
This is Rietveld 408576698