device: Build device_bluetooth target as static_library.

device: Build device_bluetooth target as static_library.

Ideally we should change this to <(component). But it needs more changes to
be able to be built as shared_library. Which should be done in a follow up CL.

BUG=111541
R=satorux@chromium.org,bryeung@chromium.org
NOTRY=True


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164914

[tfarina, 2012-10-26 21:14:51]

Hi Scott, could you review this to me?

[keybuk, 2012-10-26 21:39:44]

On 2012/10/26 21:14:51, tfarina wrote:
> Hi Scott, could you review this to me?

what is the rationale for the change, and what difference does it make?

[tfarina, 2012-10-26 21:40:30]

On 2012/10/26 21:39:44, keybuk wrote:
> On 2012/10/26 21:14:51, tfarina wrote:
> > Hi Scott, could you review this to me?
> 
> what is the rationale for the change, and what difference does it make?

Did you read the description of the bug?

[keybuk, 2012-10-26 21:42:14]

On 2012/10/26 21:40:30, tfarina wrote:
> On 2012/10/26 21:39:44, keybuk wrote:
> > On 2012/10/26 21:14:51, tfarina wrote:
> > > Hi Scott, could you review this to me?
> > 
> > what is the rationale for the change, and what difference does it make?
> 
> Did you read the description of the bug?

yes, but I didn't really follow - I'm not hugely familiar with Chrome's build
system

[tfarina, 2012-10-26 21:45:29]

On Fri, Oct 26, 2012 at 7:42 PM,  <keybuk@chromium.org> wrote:
> On 2012/10/26 21:40:30, tfarina wrote:
>>
>> On 2012/10/26 21:39:44, keybuk wrote:
>> > On 2012/10/26 21:14:51, tfarina wrote:
>> > > Hi Scott, could you review this to me?
>> >
>> > what is the rationale for the change, and what difference does it make?
>
>
>> Did you read the description of the bug?
>
>
> yes, but I didn't really follow - I'm not hugely familiar with Chrome's
> build
> system
>
What it says is that <(library) is deprecated and should not be used.
Instead modules/packages should use <(component), so we can built it
either static_library or shared_library (I have this in my
include.gypi, 'component': 'shared_library'). By using <(library) it
means it's always built as static_library.

$ g gs "<(library)" | grep -v third_party/ | wc -l
2 # excluding my changes to device.gyp

If it's clear yet I can ask on chromium-dev for more clarification.

-- 
Thiago

[tfarina, 2012-10-26 21:46:21]

On Fri, Oct 26, 2012 at 7:45 PM, Thiago Farina <tfarina@chromium.org> wrote:
> If it's clear yet I can ask on chromium-dev for more clarification.
>
s/If it's/ If it isn't clear



-- 
Thiago

[keybuk, 2012-10-26 21:52:21]

I'd rather someone more familiar with this reviewed it.

Plus you need OWNERS anyway

[tfarina, 2012-10-26 21:55:05]

On Fri, Oct 26, 2012 at 7:52 PM,  <keybuk@chromium.org> wrote:
> I'd rather someone more familiar with this reviewed it.
>
> Plus you need OWNERS anyway
>
Ahh, I didn't see that now we have device/OWNERS, so I went with
device/bluetooth/OWNERS. Pardon me.

I'm not familiar with the other reviewers though. Who might be better
to ask, who is generally more available?

-- 
Thiago

[keybuk, 2012-10-26 21:56:47]

since evan@ filed the bug, maybe him?

[tfarina, 2012-10-26 21:57:56]

On Fri, Oct 26, 2012 at 7:56 PM,  <keybuk@chromium.org> wrote:
> since evan@ filed the bug, maybe him?
>
No, he doesn't work on chromium anymore [1]

[1] - http://neugierig.org/software/chromium/notes/2012/02/the-end.html

-- 
Thiago

[tfarina, 2012-10-26 22:06:31]

Hi Satoru-san and Bryan, could you review this to me?

Thanks!

[satorux1, 2012-10-29 04:38:33]

LGTM. Not sure if this helps migration to component build, but this doesn't seem
to be harmful, and is consistent with dbus/dbus.gyp

[bryeung, 2012-10-29 13:53:13]

lgtm

[commit-bot: I haz the power, 2012-10-30 14:16:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/11276052/1

[commit-bot: I haz the power, 2012-10-30 14:38:07]

Change committed as 164914