Add upload identifier to URLRequest::Start net log event.

Add upload identifier to URLRequest::Start net log event.

BUG=145070
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164550

[cbentzel, 2012-10-26 19:46:52]

I briefly considered adding int64 support to base::Value but thought it would be
overkill for just this case. If there are other places that could use it then I
will re-evaluate.

[mmenke, 2012-10-26 19:54:15]

Should also update net_log_event_type_list.h to mention the new parameter.

http://codereview.chromium.org/11276050/diff/1/net/url_request/url_request_ne...
File net/url_request/url_request_netlog_params.cc (right):

http://codereview.chromium.org/11276050/diff/1/net/url_request/url_request_ne...
net/url_request/url_request_netlog_params.cc:26: dict->SetString("upload_id",
base::StringPrintf("%" PRId64, upload_id));
base::Int64ToString(upload_id) is a little prettier.  Declared in
base/string_number_conversions.h.

[cbentzel, 2012-10-26 20:30:08]

Documented the new field (and priority, which was missing).

http://codereview.chromium.org/11276050/diff/1/net/url_request/url_request_ne...
File net/url_request/url_request_netlog_params.cc (right):

http://codereview.chromium.org/11276050/diff/1/net/url_request/url_request_ne...
net/url_request/url_request_netlog_params.cc:26: dict->SetString("upload_id",
base::StringPrintf("%" PRId64, upload_id));
On 2012/10/26 19:54:15, Matt Menke wrote:
> base::Int64ToString(upload_id) is a little prettier.  Declared in
> base/string_number_conversions.h.

Done.

[mmenke, 2012-10-26 20:31:21]

LGTM

[commit-bot: I haz the power, 2012-10-26 23:54:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/11276050/11002

[commit-bot: I haz the power, 2012-10-27 10:56:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/11276050/7004

[commit-bot: I haz the power, 2012-10-27 12:23:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/11276050/7004

[commit-bot: I haz the power, 2012-10-27 18:24:28]

Change committed as 164550