Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 11276036: Fix "Get more extensions" link in about:extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/base64.h" 8 #include "base/base64.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 localized_strings->SetString("extensionSettings", 248 localized_strings->SetString("extensionSettings",
249 l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE)); 249 l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE));
250 250
251 localized_strings->SetString("extensionSettingsDeveloperMode", 251 localized_strings->SetString("extensionSettingsDeveloperMode",
252 l10n_util::GetStringUTF16(IDS_EXTENSIONS_DEVELOPER_MODE_LINK)); 252 l10n_util::GetStringUTF16(IDS_EXTENSIONS_DEVELOPER_MODE_LINK));
253 localized_strings->SetString("extensionSettingsNoExtensions", 253 localized_strings->SetString("extensionSettingsNoExtensions",
254 l10n_util::GetStringUTF16(IDS_EXTENSIONS_NONE_INSTALLED)); 254 l10n_util::GetStringUTF16(IDS_EXTENSIONS_NONE_INSTALLED));
255 localized_strings->SetString("extensionSettingsSuggestGallery", 255 localized_strings->SetString("extensionSettingsSuggestGallery",
256 l10n_util::GetStringFUTF16(IDS_EXTENSIONS_NONE_INSTALLED_SUGGEST_GALLERY, 256 l10n_util::GetStringFUTF16(IDS_EXTENSIONS_NONE_INSTALLED_SUGGEST_GALLERY,
257 ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 257 ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
258 GURL(extension_urls::GetWebstoreLaunchURL())).spec()))); 258 GURL(extension_urls::GetExtensionGalleryURL())).spec())));
259 // TODO(aa): Is this even used anymore?.
259 localized_strings->SetString("extensionSettingsGetMoreExtensionsDeprecated", 260 localized_strings->SetString("extensionSettingsGetMoreExtensionsDeprecated",
260 l10n_util::GetStringFUTF16(IDS_GET_MORE_EXTENSIONS_DEPRECATED, 261 l10n_util::GetStringFUTF16(IDS_GET_MORE_EXTENSIONS_DEPRECATED,
261 ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 262 ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
262 GURL(extension_urls::GetWebstoreLaunchURL())).spec()))); 263 GURL(extension_urls::GetExtensionGalleryURL())).spec())));
263 localized_strings->SetString("extensionSettingsGetMoreExtensions", 264 localized_strings->SetString("extensionSettingsGetMoreExtensions",
264 l10n_util::GetStringUTF16(IDS_GET_MORE_EXTENSIONS)); 265 l10n_util::GetStringUTF16(IDS_GET_MORE_EXTENSIONS));
265 localized_strings->SetString("extensionSettingsGetMoreExtensionsUrl", 266 localized_strings->SetString("extensionSettingsGetMoreExtensionsUrl",
266 ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 267 ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
267 GURL(extension_urls::GetWebstoreLaunchURL())).spec())); 268 GURL(extension_urls::GetExtensionGalleryURL())).spec()));
268 localized_strings->SetString("extensionSettingsExtensionId", 269 localized_strings->SetString("extensionSettingsExtensionId",
269 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID)); 270 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID));
270 localized_strings->SetString("extensionSettingsExtensionPath", 271 localized_strings->SetString("extensionSettingsExtensionPath",
271 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PATH)); 272 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PATH));
272 localized_strings->SetString("extensionSettingsInspectViews", 273 localized_strings->SetString("extensionSettingsInspectViews",
273 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS)); 274 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS));
274 localized_strings->SetString("extensionSettingsInstallWarnings", 275 localized_strings->SetString("extensionSettingsInstallWarnings",
275 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALL_WARNINGS)); 276 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALL_WARNINGS));
276 localized_strings->SetString("viewIncognito", 277 localized_strings->SetString("viewIncognito",
277 l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO)); 278 l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO));
(...skipping 680 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 std::vector<std::string> requirement_errors) { 959 std::vector<std::string> requirement_errors) {
959 if (requirement_errors.empty()) { 960 if (requirement_errors.empty()) {
960 extension_service_->EnableExtension(extension_id); 961 extension_service_->EnableExtension(extension_id);
961 } else { 962 } else {
962 ExtensionErrorReporter::GetInstance()->ReportError( 963 ExtensionErrorReporter::GetInstance()->ReportError(
963 UTF8ToUTF16(JoinString(requirement_errors, ' ')), 964 UTF8ToUTF16(JoinString(requirement_errors, ' ')),
964 true /* be noisy */); 965 true /* be noisy */);
965 } 966 }
966 requirements_checker_.reset(); 967 requirements_checker_.reset();
967 } 968 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698