Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 11275320: app_list: Make over scroll animation faster. (Closed)

Created:
8 years, 1 month ago by xiyuan
Modified:
8 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

app_list: Make over scroll animation faster. - Add an over scroll animation duration of 50ms; - Use the over scroll animation duration for transition to invalid page (i.e. over scroll); This was using normal page transition duration of 180ms before. - Use the same duration for snap back animation; This was 100ms and now changed to 50ms. Also fixed a bug that app launcher bubble moves to wrong location if starting an over scroll before previous over scroll snap back animation finishes. BUG=160590 TEST=Verify over scroll animation is fast enough. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -36 lines) Patch
M ash/wm/app_list_controller.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ui/app_list/app_list_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/app_list/apps_grid_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/contents_view.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/app_list/pagination_model.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/app_list/pagination_model.cc View 6 chunks +21 lines, -21 lines 0 comments Download
M ui/app_list/pagination_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
8 years, 1 month ago (2012-11-14 18:41:52 UTC) #1
sky
LGTM
8 years, 1 month ago (2012-11-14 22:02:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/11275320/1
8 years, 1 month ago (2012-11-14 22:07:42 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-15 00:26:09 UTC) #4
Change committed as 167784

Powered by Google App Engine
This is Rietveld 408576698