Issue 11275306: Revert 167627 - HTTP server for testing Google APIs

Issue 11275306: Revert 167627 - HTTP server for testing Google APIs (Closed)

Created:
8 years, 1 month ago by Hironori Bono

Modified:
8 years, 1 month ago

Reviewers:
satorux1

CC:
chromium-reviews, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 167627 - HTTP server for testing Google APIs The patch was copied from http://codereview.chromium.org/11088073/ so satorux could address comments from thestig on behalf of mtomasz. BUG=148710 TEST=none; the code is only for testing and won't be used for production. Review URL: https://codereview.chromium.org/11358227 Patch from Tomasz Mikolajewski <mtomasz@chromium.org>;. TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167629

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -1175 lines)			Patch
M	chrome/browser/google_apis/DEPS	View	1 chunk	+1 line, -5 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_connection.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_connection.cc	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_request.h	View	1 chunk	+0 lines, -114 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_request.cc	View	1 chunk	+0 lines, -203 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_request_unittest.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_response.h	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_response.cc	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_response_unittest.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_server.h	View	1 chunk	+0 lines, -146 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_server.cc	View	1 chunk	+0 lines, -224 lines	0 comments	Download
D	chrome/browser/google_apis/test_server/http_server_unittest.cc	View	1 chunk	+0 lines, -139 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	2 chunks	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings, Apologies for reverting your change. I have reverted your r167627 due to build breaks ...

8 years, 1 month ago (2012-11-14 09:05:05 UTC) #2

satorux1

8 years, 1 month ago (2012-11-14 10:16:29 UTC) #3

Oops. I thought try was green, but I missed the error from win_rel. Seems
to me that one of the enum members are defined as macro on Windows...

Thank you for reverting anyway.

On Wed, Nov 14, 2012 at 6:05 PM, <hbono@chromium.org> wrote:

> Greetings,

> Apologies for reverting your change. I have reverted your r167627 due to
> build
> breaks on a couple of Windows bots: "Win Builder" and "Win Builder (dbg)".

> (*1)
> http://build.chromium.org/p/**chromium.win/builders/Win%**
>
20Builder/builds/3493/steps/**compile/logs/stdio<http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/3493/steps/compile/logs/stdio>
> (*2)
> http://build.chromium.org/p/**chromium.win/builders/Win%**
>
20Builder%20%28dbg%29/builds/**4701/steps/compile/logs/stdio<http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/4701/steps/compile/logs/stdio>

> Regards,

> Hironori Bono

>
https://codereview.chromium.**org/11275306/<https://codereview.chromium.org/1...

Expand Messages | Collapse Messages