Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 11275285: Updating ASAN stub with new API (Closed)

Created:
8 years, 1 month ago by glotov
Modified:
8 years, 1 month ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Updating ASAN stub with new API BUG=chromium-os:34523 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167656

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/pyautolib/asan_stub.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
glotov
hi!
8 years, 1 month ago (2012-11-13 16:40:50 UTC) #1
Alexander Potapenko
https://codereview.chromium.org/11275285/diff/1/chrome/test/pyautolib/asan_stub.c File chrome/test/pyautolib/asan_stub.c (right): https://codereview.chromium.org/11275285/diff/1/chrome/test/pyautolib/asan_stub.c#newcode76 chrome/test/pyautolib/asan_stub.c:76: void __asan_set_error_report_callback(); I guess there should also be the ...
8 years, 1 month ago (2012-11-13 16:47:19 UTC) #2
glotov
https://codereview.chromium.org/11275285/diff/1/chrome/test/pyautolib/asan_stub.c File chrome/test/pyautolib/asan_stub.c (right): https://codereview.chromium.org/11275285/diff/1/chrome/test/pyautolib/asan_stub.c#newcode76 chrome/test/pyautolib/asan_stub.c:76: void __asan_set_error_report_callback(); Yes, right! On 2012/11/13 16:47:19, Alexander Potapenko ...
8 years, 1 month ago (2012-11-13 16:52:15 UTC) #3
Alexander Potapenko
LGTM
8 years, 1 month ago (2012-11-13 16:53:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11275285/4001
8 years, 1 month ago (2012-11-13 16:58:15 UTC) #5
commit-bot: I haz the power
Presubmit check for 11275285-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-13 16:58:18 UTC) #6
glotov
Hi Nirnimesh, could you please approve.
8 years, 1 month ago (2012-11-13 17:00:31 UTC) #7
dennis_jeffrey
LGTM Nirnimesh has moved on to another project.
8 years, 1 month ago (2012-11-13 17:24:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11275285/4001
8 years, 1 month ago (2012-11-13 17:35:36 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-13 20:14:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/11275285/4001
8 years, 1 month ago (2012-11-14 11:01:58 UTC) #11
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 12:06:23 UTC) #12
Change committed as 167656

Powered by Google App Engine
This is Rietveld 408576698