[cros,rlz] Financial ping livelock fix and proper shutdown.

[cros,rlz] Financial ping livelock fix and proper shutdown.

*) Fix the livelock on RLZ thread in FinancialPing
*) RlzValueStore on chromeos destroys JsonPrefStore on proper thread.


BUG=157348
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168187

[Roger Tawa OOO till Jul 10th, 2012-11-15 16:06:19]

lgtm

Where is CleanupRlz() called from?

http://codereview.chromium.org/11275284/diff/2001/build/common.gypi
File build/common.gypi (left):

http://codereview.chromium.org/11275284/diff/2001/build/common.gypi#oldcode1411
build/common.gypi:1411: ['branding=="Chrome" and (OS=="win" or OS=="mac")', {
this line won't be committed right?

[Ivan Korotkov, 2012-11-15 16:30:15]

CleanupRlz will be called from RLZTracker::CleanupRlz which is called on browser
shutdown. The reason for that is to called JsonPrefStore destructor on the
proper (rlz) thread instead of the global thread where atexit() happens.

http://codereview.chromium.org/11275284/diff/2001/build/common.gypi
File build/common.gypi (left):

http://codereview.chromium.org/11275284/diff/2001/build/common.gypi#oldcode1411
build/common.gypi:1411: ['branding=="Chrome" and (OS=="win" or OS=="mac")', {
On 2012/11/15 16:06:19, Roger Tawa wrote:
> this line won't be committed right?

Right, this is for trybots.

[commit-bot: I haz the power, 2012-11-16 09:30:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/11275284/9001

[commit-bot: I haz the power, 2012-11-16 11:16:40]

Change committed as 168187