Fix assert in Page::Initialize.

src/spaces-inl.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 146 matching lines @@
 #endif
 
 
 // --------------------------------------------------------------------------
 // PagedSpace
 Page* Page::Initialize(Heap* heap,
                        MemoryChunk* chunk,
                        Executability executable,
                        PagedSpace* owner) {
   Page* page = reinterpret_cast<Page*>(chunk);
-  ASSERT(chunk->size() <= static_cast<size_t>(kPageSize));
+  ASSERT(page->area_size() <= kPageSize);

[Michael Starzinger, 2012/11/14 14:43:54]

This should actually be ASSERT(page->area_size() <= kNonCodeObjectAreaSize);

+  // Code range allocation can return chunks larger than a page.
+  ASSERT(chunk->size() <= static_cast<size_t>(kPageSize) ||

[Michael Starzinger, 2012/11/14 14:43:54]

I am not sure if we should even have this second assertion anymore. If nobody
beside the MemoryAllocator should rely on chunk->size() being a special size, we
should not assert it here. So I think we should completely remove the second
assert, but could be convinced otherwise.

+         executable == EXECUTABLE);
   ASSERT(chunk->owner() == owner);
   owner->IncreaseCapacity(page->area_size());
   owner->Free(page->area_start(), page->area_size());
 
   heap->incremental_marking()->SetOldSpacePageFlags(chunk);
 
   return page;
 }
 
 
@@ skipping 194 matching lines @@
   Map* map = object->map();
   Heap* heap = object->GetHeap();
   return map == heap->raw_unchecked_free_space_map()
       || map == heap->raw_unchecked_one_pointer_filler_map()
       || map == heap->raw_unchecked_two_pointer_filler_map();
 }
 
 } }  // namespace v8::internal
 
 #endif  // V8_SPACES_INL_H_