Chromium Code Reviews
Help | Chromium Project | Sign in
(243)

Issue 11275186: Collect stack trace on stack overflow. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by Yang
Modified:
2 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Collect stack trace on stack overflow. BUG=v8:2394 Committed: https://code.google.com/p/v8/source/detail?r=12933

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : . #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -133 lines) Patch
M src/isolate.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M src/isolate.cc View 1 2 2 chunks +112 lines, -6 lines 4 comments Download
M src/messages.js View 1 2 3 3 chunks +49 lines, -27 lines 0 comments Download
M src/runtime.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 3 2 chunks +15 lines, -90 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 2 chunks +20 lines, -9 lines 0 comments Download
A test/mjsunit/stack-traces-overflow.js View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Yang
PTAL. http://codereview.chromium.org/11275186/diff/1/src/isolate.cc File src/isolate.cc (right): http://codereview.chromium.org/11275186/diff/1/src/isolate.cc#newcode561 src/isolate.cc:561: // yet. This part is simply moved over ...
2 years, 8 months ago (2012-11-07 11:02:38 UTC) #1
Yang
On 2012/11/07 11:02:38, Yang wrote: > PTAL. > > http://codereview.chromium.org/11275186/diff/1/src/isolate.cc > File src/isolate.cc (right): > ...
2 years, 8 months ago (2012-11-09 10:56:34 UTC) #2
Sven Panne
2 years, 8 months ago (2012-11-09 12:25:52 UTC) #3
LGTM with nits

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode562
src/isolate.cc:562: bool ShowFrameInStackTrace(StackFrame* raw_frame,
Make this static or a method of StackFrame. Furthermore, the name should make it
clearer that this is a predicate, e.g. IsVisibleInStackTrace.

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode566
src/isolate.cc:566: if (!raw_frame->is_java_script()) {
Just for consistency: One-liner if...

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode572
src/isolate.cc:572: if (!raw_fun->IsJSFunction()) {
Again just for consistency: One-liner if...

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode611
src/isolate.cc:611: while (!iter.done() && frames_seen < limit) {
A for-loop with a conditional break in it might be more readable.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5