Not opening File Manager as an app on Ctrl+O.

Not opening File Manager as an app on Ctrl+O.

BUG=158930
TEST=Manual test.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166454

[Vladislav Kaznacheev, 2012-11-06 14:09:17]

https://chromiumcodereview.appspot.com/11275165/diff/1/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://chromiumcodereview.appspot.com/11275165/diff/1/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_shell_delegate.cc:211:
file_manager_util::OpenApplication();
You are changing the behavior but the comment above is still describing the old
behavior

[SeRya, 2012-11-06 15:36:16]

https://chromiumcodereview.appspot.com/11275165/diff/1/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://chromiumcodereview.appspot.com/11275165/diff/1/chrome/browser/ui/ash/...
chrome/browser/ui/ash/chrome_shell_delegate.cc:211:
file_manager_util::OpenApplication();
On 2012/11/06 14:09:17, Vladislav Kaznacheev wrote:
> You are changing the behavior but the comment above is still describing the
old
> behavior

The comment updated.

[sky, 2012-11-06 16:46:57]

https://codereview.chromium.org/11275165/diff/5001/chrome/browser/ui/ash/chro...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/11275165/diff/5001/chrome/browser/ui/ash/chro...
chrome/browser/ui/ash/chrome_shell_delegate.cc:200: #if defined(OS_CHROMEOS)
Why is any of this in an ifdef?

[SeRya, 2012-11-07 07:27:23]

https://chromiumcodereview.appspot.com/11275165/diff/5001/chrome/browser/ui/a...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://chromiumcodereview.appspot.com/11275165/diff/5001/chrome/browser/ui/a...
chrome/browser/ui/ash/chrome_shell_delegate.cc:200: #if defined(OS_CHROMEOS)
On 2012/11/06 16:46:58, sky wrote:
> Why is any of this in an ifdef?

Because file_manager_util is available in ChromeOS but not in Ash on Windows for
instance. May be it's wrong but it's a separate issue.

[sky, 2012-11-07 14:41:52]

LGTM

[commit-bot: I haz the power, 2012-11-07 14:59:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/serya@chromium.org/11275165/5001

[commit-bot: I haz the power, 2012-11-07 16:57:04]

Change committed as 166454