chrome/browser/password_manager/password_store_x_unittest.cc - Issue 11275088: Remove implicit scoped_refptr operator T*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store.cc ('k') | chrome/browser/policy/cloud_policy_refresh_scheduler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_x_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc

index 55d2d3c5a40be8c607f96c15032b661bbe26c807..22471c2059189f4ea94068d00865ae9e31b74f12 100644

--- a/chrome/browser/password_manager/password_store_x_unittest.cc

+++ b/chrome/browser/password_manager/password_store_x_unittest.cc

@@ -331,7 +331,7 @@ TEST_P(PasswordStoreXTest, Notifications) {

scoped_ptr<PasswordForm> form(CreatePasswordFormFromData(form_data));

scoped_refptr<DBThreadObserverHelper> helper = new DBThreadObserverHelper;

- helper->Init(store);

+ helper->Init(store.get());

const PasswordStoreChange expected_add_changes[] = {

PasswordStoreChange(PasswordStoreChange::ADD, *form),

@@ -339,7 +339,7 @@ TEST_P(PasswordStoreXTest, Notifications) {

EXPECT_CALL(helper->observer(),

Observe(int(chrome::NOTIFICATION_LOGINS_CHANGED),

- content::Source<PasswordStore>(store),

+ content::Source<PasswordStore>(store.get()),

Property(&content::Details<const PasswordStoreChangeList>::ptr,

Pointee(ElementsAreArray(

expected_add_changes)))));

@@ -363,7 +363,7 @@ TEST_P(PasswordStoreXTest, Notifications) {

EXPECT_CALL(helper->observer(),

Observe(int(chrome::NOTIFICATION_LOGINS_CHANGED),

- content::Source<PasswordStore>(store),

+ content::Source<PasswordStore>(store.get()),

Property(&content::Details<const PasswordStoreChangeList>::ptr,

Pointee(ElementsAreArray(

expected_update_changes)))));

@@ -382,7 +382,7 @@ TEST_P(PasswordStoreXTest, Notifications) {

EXPECT_CALL(helper->observer(),

Observe(int(chrome::NOTIFICATION_LOGINS_CHANGED),

- content::Source<PasswordStore>(store),

+ content::Source<PasswordStore>(store.get()),

Property(&content::Details<const PasswordStoreChangeList>::ptr,

Pointee(ElementsAreArray(

expected_delete_changes)))));

@@ -396,7 +396,7 @@ TEST_P(PasswordStoreXTest, Notifications) {

done.Wait();

// Public in PasswordStore, protected in PasswordStoreX.

- static_cast<PasswordStore*>(store)->ShutdownOnUIThread();

+ static_cast<PasswordStore*>(store.get())->ShutdownOnUIThread();

}

TEST_P(PasswordStoreXTest, NativeMigration) {

@@ -533,7 +533,7 @@ TEST_P(PasswordStoreXTest, NativeMigration) {

STLDeleteElements(&expected_blacklisted);

// Public in PasswordStore, protected in PasswordStoreX.

- static_cast<PasswordStore*>(store)->ShutdownOnUIThread();

+ static_cast<PasswordStore*>(store.get())->ShutdownOnUIThread();

}

INSTANTIATE_TEST_CASE_P(NoBackend,