base/memory/weak_ptr.h - Issue 11275088: Remove implicit scoped_refptr operator T*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/weak_ptr.h

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/weak_ptr.h

diff --git a/base/memory/weak_ptr.h b/base/memory/weak_ptr.h

index 7006fb63e0981468e30ac2c631e8d6c1ed645ef7..49309acd6abb12014a338da00fc248189f8414b1 100644

--- a/base/memory/weak_ptr.h

+++ b/base/memory/weak_ptr.h

@@ -133,7 +133,7 @@ class BASE_EXPORT WeakReferenceOwner {

// Indicates that this object will be used on another thread from now on.

void DetachFromThread() {

- if (flag_) flag_->DetachFromThread();

+ if (flag_.get()) flag_->DetachFromThread();

}

private:

« no previous file with comments | « base/memory/ref_counted.h ('k') | base/memory/weak_ptr.cc » ('j') | no next file with comments »