chrome/browser/extensions/api/extension_action/extension_actions_api.cc - Issue 11275088: Remove implicit scoped_refptr operator T*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_unittest.cc ('k') | chrome/browser/extensions/api/management/management_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

index b741308da593940ccf540472193ef668a2f0fbe8..6b69a170b3e8ad40b2036b29b79335022c146df9 100644

--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc

@@ -366,12 +366,12 @@ void ExtensionActionFunction::NotifyChange() {

case extensions::Extension::ActionInfo::TYPE_PAGE:

if (extensions::ExtensionActionManager::Get(profile_)->

GetBrowserAction(*extension_)) {

- NotifyBrowserActionChange();

- } else if (extensions::ExtensionActionManager::Get(profile_)->

- GetPageAction(*extension_)) {

- NotifyLocationBarChange();

- }

- return;

+ NotifyBrowserActionCextension_.get()

+ } else if (extensions::ExtensionActionManager::Get(profile_)->

+ GetPageAction(*extension_)) {

+ NotifyLocationBarChange(extension_.get()

+ }

+ return;

case extensions::Extension::ActionInfo::TYPE_SCRIPT_BADGE:

NotifyLocationBarChange();

return;