Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: webkit/appcache/appcache_storage_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_storage_impl.cc ('k') | webkit/appcache/appcache_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_storage_unittest.cc
diff --git a/webkit/appcache/appcache_storage_unittest.cc b/webkit/appcache/appcache_storage_unittest.cc
index a5ad0b70dede6cef6e781d213815cf766d1dfe99..51e31c9c8c40e26ef53c73790f0de2aa3cf3190c 100644
--- a/webkit/appcache/appcache_storage_unittest.cc
+++ b/webkit/appcache/appcache_storage_unittest.cc
@@ -31,13 +31,13 @@ TEST_F(AppCacheStorageTest, AddRemoveCache) {
EXPECT_EQ(cache.get(),
service.storage()->working_set()->GetCache(111));
- service.storage()->working_set()->RemoveCache(cache);
+ service.storage()->working_set()->RemoveCache(cache.get());
EXPECT_TRUE(!service.storage()->working_set()->GetCache(111));
// Removing non-existing cache from service should not fail.
MockAppCacheService dummy;
- dummy.storage()->working_set()->RemoveCache(cache);
+ dummy.storage()->working_set()->RemoveCache(cache.get());
}
TEST_F(AppCacheStorageTest, AddRemoveGroup) {
@@ -46,13 +46,13 @@ TEST_F(AppCacheStorageTest, AddRemoveGroup) {
EXPECT_EQ(group.get(), service.storage()->working_set()->GetGroup(GURL()));
- service.storage()->working_set()->RemoveGroup(group);
+ service.storage()->working_set()->RemoveGroup(group.get());
EXPECT_TRUE(!service.storage()->working_set()->GetGroup(GURL()));
// Removing non-existing group from service should not fail.
MockAppCacheService dummy;
- dummy.storage()->working_set()->RemoveGroup(group);
+ dummy.storage()->working_set()->RemoveGroup(group.get());
}
TEST_F(AppCacheStorageTest, AddRemoveResponseInfo) {
@@ -65,13 +65,13 @@ TEST_F(AppCacheStorageTest, AddRemoveResponseInfo) {
EXPECT_EQ(info.get(),
service.storage()->working_set()->GetResponseInfo(111));
- service.storage()->working_set()->RemoveResponseInfo(info);
+ service.storage()->working_set()->RemoveResponseInfo(info.get());
EXPECT_TRUE(!service.storage()->working_set()->GetResponseInfo(111));
// Removing non-existing info from service should not fail.
MockAppCacheService dummy;
- dummy.storage()->working_set()->RemoveResponseInfo(info);
+ dummy.storage()->working_set()->RemoveResponseInfo(info.get());
}
TEST_F(AppCacheStorageTest, DelegateReferences) {
@@ -119,7 +119,7 @@ TEST_F(AppCacheStorageTest, UsageMap) {
MockAppCacheService service;
scoped_refptr<quota::MockQuotaManagerProxy> mock_proxy(
new quota::MockQuotaManagerProxy(NULL, NULL));
- service.set_quota_manager_proxy(mock_proxy);
+ service.set_quota_manager_proxy(mock_proxy.get());
service.storage()->UpdateUsageMapAndNotify(kOrigin, 0);
EXPECT_EQ(0, mock_proxy->notify_storage_modified_count());
« no previous file with comments | « webkit/appcache/appcache_storage_impl.cc ('k') | webkit/appcache/appcache_test_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698