Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: net/url_request/url_request_job.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/view_cache_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job.cc
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 66fc9f3235687881e53b289889983641fcf9a10a..212629667e3f1ae70860ac4843cff60fd187ea45 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -67,7 +67,7 @@ bool URLRequestJob::Read(IOBuffer* buf, int buf_size, int *bytes_read) {
DCHECK_LT(buf_size, 1000000); // Sanity check.
DCHECK(buf);
DCHECK(bytes_read);
- DCHECK(filtered_read_buffer_ == NULL);
+ DCHECK(filtered_read_buffer_.get() == NULL);
DCHECK_EQ(0, filtered_read_buffer_len_);
*bytes_read = 0;
@@ -317,8 +317,8 @@ void URLRequestJob::NotifyHeadersComplete() {
GetAuthChallengeInfo(&auth_info);
// Need to check for a NULL auth_info because the server may have failed
// to send a challenge with the 401 response.
- if (auth_info) {
- request_->NotifyAuthRequired(auth_info);
+ if (auth_info.get()) {
+ request_->NotifyAuthRequired(auth_info.get());
// Wait for SetAuth or CancelAuth to be called.
return;
}
@@ -484,10 +484,13 @@ void URLRequestJob::FilteredDataRead(int bytes_read) {
bool URLRequestJob::ReadFilteredData(int* bytes_read) {
DCHECK(filter_.get()); // don't add data if there is no filter
- DCHECK(filtered_read_buffer_ != NULL); // we need to have a buffer to fill
+ DCHECK(
+ filtered_read_buffer_.get() != NULL); // we need to have a buffer to fill
DCHECK_GT(filtered_read_buffer_len_, 0); // sanity check
DCHECK_LT(filtered_read_buffer_len_, 1000000); // sanity check
- DCHECK(raw_read_buffer_ == NULL); // there should be no raw read buffer yet
+ DCHECK(
+ raw_read_buffer_.get() ==
+ NULL); // there should be no raw read buffer yet
bool rv = false;
*bytes_read = 0;
@@ -643,7 +646,7 @@ bool URLRequestJob::ReadRawDataForFilter(int* bytes_read) {
bool URLRequestJob::ReadRawDataHelper(IOBuffer* buf, int buf_size,
int* bytes_read) {
DCHECK(!request_->status().is_io_pending());
- DCHECK(raw_read_buffer_ == NULL);
+ DCHECK(raw_read_buffer_.get() == NULL);
// Keep a pointer to the read buffer, so we have access to it in the
// OnRawReadComplete() callback in the event that the read completes
« no previous file with comments | « net/url_request/url_request_ftp_job.cc ('k') | net/url_request/view_cache_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698