Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2271)

Unified Diff: net/spdy/spdy_http_stream_spdy2_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_http_stream.cc ('k') | net/spdy/spdy_proxy_client_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_http_stream_spdy2_unittest.cc
diff --git a/net/spdy/spdy_http_stream_spdy2_unittest.cc b/net/spdy/spdy_http_stream_spdy2_unittest.cc
index 83094f2eff6e35ecebdeebe437b841633937f599..35b1550fb777832fd278d6139c199c046576c4ea 100644
--- a/net/spdy/spdy_http_stream_spdy2_unittest.cc
+++ b/net/spdy/spdy_http_stream_spdy2_unittest.cc
@@ -164,7 +164,7 @@ TEST_F(SpdyHttpStreamSpdy2Test, SendChunkedPost) {
http_stream.InitializeStream(&request, net_log, CompletionCallback()));
scoped_ptr<UploadDataStream> upload_stream(
- new UploadDataStream(request.upload_data));
+ new UploadDataStream(request.upload_data.get()));
ASSERT_EQ(OK, upload_stream->InitSync());
EXPECT_EQ(ERR_IO_PENDING, http_stream.SendRequest(
headers, upload_stream.Pass(), &response, callback.callback()));
@@ -259,7 +259,7 @@ TEST_F(SpdyHttpStreamSpdy2Test, DelayedSendChunkedPost) {
CompletionCallback()));
scoped_ptr<UploadDataStream> upload_stream(
- new UploadDataStream(request.upload_data));
+ new UploadDataStream(request.upload_data.get()));
ASSERT_EQ(OK, upload_stream->InitSync());
request.upload_data->AppendChunk(kUploadData, kUploadDataSize, false);
@@ -295,7 +295,7 @@ TEST_F(SpdyHttpStreamSpdy2Test, DelayedSendChunkedPost) {
data.RunFor(1);
scoped_refptr<IOBuffer> buf1(new IOBuffer(kUploadDataSize));
ASSERT_EQ(kUploadDataSize,
- http_stream->ReadResponseBody(buf1,
+ http_stream->ReadResponseBody(buf1.get(),
kUploadDataSize,
callback.callback()));
EXPECT_EQ(kUploadData, std::string(buf1->data(), kUploadDataSize));
@@ -304,7 +304,7 @@ TEST_F(SpdyHttpStreamSpdy2Test, DelayedSendChunkedPost) {
data.RunFor(1);
scoped_refptr<IOBuffer> buf2(new IOBuffer(kUploadData1Size));
ASSERT_EQ(kUploadData1Size,
- http_stream->ReadResponseBody(buf2,
+ http_stream->ReadResponseBody(buf2.get(),
kUploadData1Size,
callback.callback()));
EXPECT_EQ(kUploadData1, std::string(buf2->data(), kUploadData1Size));
@@ -313,7 +313,7 @@ TEST_F(SpdyHttpStreamSpdy2Test, DelayedSendChunkedPost) {
data.RunFor(1);
scoped_refptr<IOBuffer> buf3(new IOBuffer(kUploadDataSize));
ASSERT_EQ(kUploadDataSize,
- http_stream->ReadResponseBody(buf3,
+ http_stream->ReadResponseBody(buf3.get(),
kUploadDataSize,
callback.callback()));
EXPECT_EQ(kUploadData, std::string(buf3->data(), kUploadDataSize));
@@ -352,7 +352,8 @@ TEST_F(SpdyHttpStreamSpdy2Test, SpdyURLTest) {
HttpResponseInfo response;
HttpRequestHeaders headers;
BoundNetLog net_log;
- scoped_ptr<SpdyHttpStream> http_stream(new SpdyHttpStream(session_, true));
+ scoped_ptr<SpdyHttpStream>
+ http_stream(new SpdyHttpStream(session_.get(), true));
ASSERT_EQ(
OK,
http_stream->InitializeStream(&request, net_log, CompletionCallback()));
« no previous file with comments | « net/spdy/spdy_http_stream.cc ('k') | net/spdy/spdy_proxy_client_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698