Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/browsing_data/browsing_data_helper_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_file_system_helper.cc ('k') | chrome/browser/browsing_data/local_data_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_helper_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_helper_unittest.cc
index d3eab5d4c974663a72db6ab37699f98fbe4b86bd..9b73c456a17e8ad5e8c6d50f3e8052f3b1bc64c3 100644
--- a/chrome/browser/browsing_data/browsing_data_helper_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_helper_unittest.cc
@@ -116,44 +116,47 @@ TEST_F(BrowsingDataHelperTest, TestMatches) {
// Protect kOrigin1.
mock_policy->AddProtected(kOrigin1.GetOrigin());
- EXPECT_FALSE(Match(kOrigin1, kUnprotected, mock_policy));
- EXPECT_TRUE(Match(kOrigin2, kUnprotected, mock_policy));
- EXPECT_FALSE(Match(kOriginExt, kUnprotected, mock_policy));
- EXPECT_FALSE(Match(kOriginDevTools, kUnprotected, mock_policy));
-
- EXPECT_TRUE(Match(kOrigin1, kProtected, mock_policy));
- EXPECT_FALSE(Match(kOrigin2, kProtected, mock_policy));
- EXPECT_FALSE(Match(kOriginExt, kProtected, mock_policy));
- EXPECT_FALSE(Match(kOriginDevTools, kProtected, mock_policy));
-
- EXPECT_FALSE(Match(kOrigin1, kExtension, mock_policy));
- EXPECT_FALSE(Match(kOrigin2, kExtension, mock_policy));
- EXPECT_TRUE(Match(kOriginExt, kExtension, mock_policy));
- EXPECT_FALSE(Match(kOriginDevTools, kExtension, mock_policy));
-
- EXPECT_TRUE(Match(kOrigin1, kUnprotected | kProtected, mock_policy));
- EXPECT_TRUE(Match(kOrigin2, kUnprotected | kProtected, mock_policy));
- EXPECT_FALSE(Match(kOriginExt, kUnprotected | kProtected, mock_policy));
- EXPECT_FALSE(Match(kOriginDevTools, kUnprotected | kProtected, mock_policy));
-
- EXPECT_FALSE(Match(kOrigin1, kUnprotected | kExtension, mock_policy));
- EXPECT_TRUE(Match(kOrigin2, kUnprotected | kExtension, mock_policy));
- EXPECT_TRUE(Match(kOriginExt, kUnprotected | kExtension, mock_policy));
- EXPECT_FALSE(Match(kOriginDevTools, kUnprotected | kExtension, mock_policy));
-
- EXPECT_TRUE(Match(kOrigin1, kProtected | kExtension, mock_policy));
- EXPECT_FALSE(Match(kOrigin2, kProtected | kExtension, mock_policy));
- EXPECT_TRUE(Match(kOriginExt, kProtected | kExtension, mock_policy));
- EXPECT_FALSE(Match(kOriginDevTools, kProtected | kExtension, mock_policy));
+ EXPECT_FALSE(Match(kOrigin1, kUnprotected, mock_policy.get()));
+ EXPECT_TRUE(Match(kOrigin2, kUnprotected, mock_policy.get()));
+ EXPECT_FALSE(Match(kOriginExt, kUnprotected, mock_policy.get()));
+ EXPECT_FALSE(Match(kOriginDevTools, kUnprotected, mock_policy.get()));
+
+ EXPECT_TRUE(Match(kOrigin1, kProtected, mock_policy.get()));
+ EXPECT_FALSE(Match(kOrigin2, kProtected, mock_policy.get()));
+ EXPECT_FALSE(Match(kOriginExt, kProtected, mock_policy.get()));
+ EXPECT_FALSE(Match(kOriginDevTools, kProtected, mock_policy.get()));
+
+ EXPECT_FALSE(Match(kOrigin1, kExtension, mock_policy.get()));
+ EXPECT_FALSE(Match(kOrigin2, kExtension, mock_policy.get()));
+ EXPECT_TRUE(Match(kOriginExt, kExtension, mock_policy.get()));
+ EXPECT_FALSE(Match(kOriginDevTools, kExtension, mock_policy.get()));
+
+ EXPECT_TRUE(Match(kOrigin1, kUnprotected | kProtected, mock_policy.get()));
+ EXPECT_TRUE(Match(kOrigin2, kUnprotected | kProtected, mock_policy.get()));
+ EXPECT_FALSE(Match(kOriginExt, kUnprotected | kProtected, mock_policy.get()));
+ EXPECT_FALSE(
+ Match(kOriginDevTools, kUnprotected | kProtected, mock_policy.get()));
+
+ EXPECT_FALSE(Match(kOrigin1, kUnprotected | kExtension, mock_policy.get()));
+ EXPECT_TRUE(Match(kOrigin2, kUnprotected | kExtension, mock_policy.get()));
+ EXPECT_TRUE(Match(kOriginExt, kUnprotected | kExtension, mock_policy.get()));
+ EXPECT_FALSE(
+ Match(kOriginDevTools, kUnprotected | kExtension, mock_policy.get()));
+
+ EXPECT_TRUE(Match(kOrigin1, kProtected | kExtension, mock_policy.get()));
+ EXPECT_FALSE(Match(kOrigin2, kProtected | kExtension, mock_policy.get()));
+ EXPECT_TRUE(Match(kOriginExt, kProtected | kExtension, mock_policy.get()));
+ EXPECT_FALSE(
+ Match(kOriginDevTools, kProtected | kExtension, mock_policy.get()));
EXPECT_TRUE(Match(kOrigin1, kUnprotected | kProtected | kExtension,
- mock_policy));
+ mock_policy.get()));
EXPECT_TRUE(Match(kOrigin2, kUnprotected | kProtected | kExtension,
- mock_policy));
+ mock_policy.get()));
EXPECT_TRUE(Match(kOriginExt, kUnprotected | kProtected | kExtension,
- mock_policy));
+ mock_policy.get()));
EXPECT_FALSE(Match(kOriginDevTools, kUnprotected | kProtected | kExtension,
- mock_policy));
+ mock_policy.get()));
}
} // namespace
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_file_system_helper.cc ('k') | chrome/browser/browsing_data/local_data_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698