Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4584)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
index 7323ef8a03baca2d61aa3f16838951c7287d1653..0861b2dbfed2d779acaea483f2c62952ed0e21a0 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
@@ -32,7 +32,7 @@ TEST_F(ExtensionManifestTest, BackgroundScripts) {
scoped_refptr<Extension> extension(
LoadAndExpectSuccess(Manifest(manifest.get(), "")));
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_EQ(2u, extension->background_scripts().size());
EXPECT_EQ("foo.js", extension->background_scripts()[0u]);
EXPECT_EQ("bar/baz.js", extension->background_scripts()[1u]);
@@ -50,7 +50,7 @@ TEST_F(ExtensionManifestTest, BackgroundScripts) {
TEST_F(ExtensionManifestTest, BackgroundPage) {
scoped_refptr<Extension> extension(
LoadAndExpectSuccess("background_page.json"));
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_EQ("/foo.html", extension->GetBackgroundURL().path());
EXPECT_TRUE(extension->allow_background_js_access());
@@ -59,7 +59,7 @@ TEST_F(ExtensionManifestTest, BackgroundPage) {
LoadManifestFile("background_page_legacy.json", &error));
ASSERT_TRUE(manifest.get());
extension = LoadAndExpectSuccess(Manifest(manifest.get(), ""));
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_EQ("/foo.html", extension->GetBackgroundURL().path());
manifest->SetInteger(keys::kManifestVersion, 2);
@@ -71,11 +71,11 @@ TEST_F(ExtensionManifestTest, BackgroundPage) {
TEST_F(ExtensionManifestTest, BackgroundAllowNoJsAccess) {
scoped_refptr<Extension> extension;
extension = LoadAndExpectSuccess("background_allow_no_js_access.json");
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_FALSE(extension->allow_background_js_access());
extension = LoadAndExpectSuccess("background_allow_no_js_access2.json");
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_FALSE(extension->allow_background_js_access());
}
@@ -93,7 +93,7 @@ TEST_F(ExtensionManifestTest, BackgroundPageWebRequest) {
manifest->SetInteger(keys::kManifestVersion, 2);
scoped_refptr<Extension> extension(
LoadAndExpectSuccess(Manifest(manifest.get(), "")));
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
EXPECT_TRUE(extension->has_lazy_background_page());
ListValue* permissions = new ListValue();

Powered by Google App Engine
This is Rietveld 408576698