| Index: chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc
|
| diff --git a/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc b/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc
|
| index 6c43830af8255877ca41b672fcff5ca03122d0ff..b5ebf6e80411c564d0e982805054d5f18fa8ffb5 100644
|
| --- a/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc
|
| +++ b/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc
|
| @@ -134,7 +134,7 @@ class SyncNonFrontendDataTypeControllerTest : public testing::Test {
|
|
|
| protected:
|
| void SetStartExpectations() {
|
| - EXPECT_CALL(*dtc_mock_, StartModels()).WillOnce(Return(true));
|
| + EXPECT_CALL(*dtc_mock_.get(), StartModels()).WillOnce(Return(true));
|
| EXPECT_CALL(model_load_callback_, Run(_, _));
|
| model_associator_ = new ModelAssociatorMock();
|
| change_processor_ = new ChangeProcessorMock();
|
| @@ -150,7 +150,7 @@ class SyncNonFrontendDataTypeControllerTest : public testing::Test {
|
| WillOnce(DoAll(SetArgumentPointee<0>(true), Return(true)));
|
| EXPECT_CALL(*model_associator_, AssociateModels()).
|
| WillOnce(Return(syncer::SyncError()));
|
| - EXPECT_CALL(*dtc_mock_, RecordAssociationTime(_));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
|
| }
|
|
|
| void SetActivateExpectations(DataTypeController::StartResult result) {
|
| @@ -159,21 +159,21 @@ class SyncNonFrontendDataTypeControllerTest : public testing::Test {
|
| }
|
|
|
| void SetStopExpectations() {
|
| - EXPECT_CALL(*dtc_mock_, StopModels());
|
| + EXPECT_CALL(*dtc_mock_.get(), StopModels());
|
| EXPECT_CALL(service_, DeactivateDataType(_));
|
| EXPECT_CALL(*model_associator_, DisassociateModels()).
|
| WillOnce(Return(syncer::SyncError()));
|
| }
|
|
|
| void SetStartFailExpectations(DataTypeController::StartResult result) {
|
| - EXPECT_CALL(*dtc_mock_, StopModels());
|
| + EXPECT_CALL(*dtc_mock_.get(), StopModels());
|
| if (DataTypeController::IsUnrecoverableResult(result))
|
| - EXPECT_CALL(*dtc_mock_, RecordUnrecoverableError(_, _));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordUnrecoverableError(_, _));
|
| if (model_associator_) {
|
| EXPECT_CALL(*model_associator_, DisassociateModels()).
|
| WillOnce(Return(syncer::SyncError()));
|
| }
|
| - EXPECT_CALL(*dtc_mock_, RecordStartFailure(result));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordStartFailure(result));
|
| EXPECT_CALL(start_callback_, Run(result,_));
|
| }
|
|
|
| @@ -233,7 +233,7 @@ TEST_F(SyncNonFrontendDataTypeControllerTest, StartFirstRun) {
|
| WillOnce(DoAll(SetArgumentPointee<0>(false), Return(true)));
|
| EXPECT_CALL(*model_associator_, AssociateModels()).
|
| WillOnce(Return(syncer::SyncError()));
|
| - EXPECT_CALL(*dtc_mock_, RecordAssociationTime(_));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
|
| SetActivateExpectations(DataTypeController::OK_FIRST_RUN);
|
| EXPECT_EQ(DataTypeController::NOT_RUNNING, non_frontend_dtc_->state());
|
| Start();
|
| @@ -250,7 +250,7 @@ TEST_F(SyncNonFrontendDataTypeControllerTest, StartAssociationFailed) {
|
| EXPECT_CALL(*model_associator_, AssociateModels()).
|
| WillOnce(
|
| Return(syncer::SyncError(FROM_HERE, "Error", syncer::AUTOFILL)));
|
| - EXPECT_CALL(*dtc_mock_, RecordAssociationTime(_));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
|
| SetStartFailExpectations(DataTypeController::ASSOCIATION_FAILED);
|
| // Set up association to fail with an association failed error.
|
| EXPECT_EQ(DataTypeController::NOT_RUNNING, non_frontend_dtc_->state());
|
| @@ -305,10 +305,11 @@ TEST_F(SyncNonFrontendDataTypeControllerTest, AbortDuringAssociationInactive) {
|
| SignalEvent(&pause_db_thread));
|
| EXPECT_CALL(*model_associator_, AssociateModels()).
|
| WillOnce(Return(syncer::SyncError()));
|
| - EXPECT_CALL(*dtc_mock_, RecordAssociationTime(_));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
|
| EXPECT_CALL(service_, ActivateDataType(_, _, _));
|
| EXPECT_CALL(start_callback_, Run(DataTypeController::ABORTED,_));
|
| - EXPECT_CALL(*dtc_mock_, RecordStartFailure(DataTypeController::ABORTED));
|
| + EXPECT_CALL(
|
| + *dtc_mock_.get(), RecordStartFailure(DataTypeController::ABORTED));
|
| SetStopExpectations();
|
| EXPECT_EQ(DataTypeController::NOT_RUNNING, non_frontend_dtc_->state());
|
| Start();
|
| @@ -334,12 +335,13 @@ TEST_F(SyncNonFrontendDataTypeControllerTest, AbortDuringAssociationActivated) {
|
| SignalEvent(&pause_db_thread));
|
| EXPECT_CALL(*model_associator_, AssociateModels()).
|
| WillOnce(Return(syncer::SyncError()));
|
| - EXPECT_CALL(*dtc_mock_, RecordAssociationTime(_));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
|
| EXPECT_CALL(service_, ActivateDataType(_, _, _)).WillOnce(DoAll(
|
| SignalEvent(&wait_for_db_thread_pause),
|
| WaitOnEvent(&pause_db_thread)));
|
| EXPECT_CALL(start_callback_, Run(DataTypeController::ABORTED,_));
|
| - EXPECT_CALL(*dtc_mock_, RecordStartFailure(DataTypeController::ABORTED));
|
| + EXPECT_CALL(
|
| + *dtc_mock_.get(), RecordStartFailure(DataTypeController::ABORTED));
|
| SetStopExpectations();
|
| EXPECT_EQ(DataTypeController::NOT_RUNNING, non_frontend_dtc_->state());
|
| Start();
|
| @@ -367,7 +369,7 @@ TEST_F(SyncNonFrontendDataTypeControllerTest,
|
| SetStartExpectations();
|
| SetAssociateExpectations();
|
| SetActivateExpectations(DataTypeController::OK);
|
| - EXPECT_CALL(*dtc_mock_, RecordUnrecoverableError(_, "Test"));
|
| + EXPECT_CALL(*dtc_mock_.get(), RecordUnrecoverableError(_, "Test"));
|
| EXPECT_CALL(service_, DisableBrokenDatatype(_,_,_)).WillOnce(
|
| InvokeWithoutArgs(non_frontend_dtc_.get(),
|
| &NonFrontendDataTypeController::Stop));
|
|
|