Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: media/base/filter_collection_unittest.cc

Issue 11275088: Remove implicit scoped_refptr operator T* Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/decoder_buffer_unittest.cc ('k') | media/base/mock_filters.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/filter_collection.h" 5 #include "media/base/filter_collection.h"
6 #include "media/base/mock_filters.h" 6 #include "media/base/mock_filters.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace media { 9 namespace media {
10 10
(...skipping 13 matching lines...) Expand all
24 scoped_refptr<AudioRenderer> audio_renderer; 24 scoped_refptr<AudioRenderer> audio_renderer;
25 25
26 collection_.SelectAudioRenderer(&audio_renderer); 26 collection_.SelectAudioRenderer(&audio_renderer);
27 EXPECT_FALSE(audio_renderer); 27 EXPECT_FALSE(audio_renderer);
28 28
29 // Add an audio decoder. 29 // Add an audio decoder.
30 collection_.AddAudioRenderer(mock_filters_.audio_renderer()); 30 collection_.AddAudioRenderer(mock_filters_.audio_renderer());
31 31
32 // Verify that we can select the audio decoder. 32 // Verify that we can select the audio decoder.
33 collection_.SelectAudioRenderer(&audio_renderer); 33 collection_.SelectAudioRenderer(&audio_renderer);
34 EXPECT_TRUE(audio_renderer); 34 EXPECT_TRUE(audio_renderer.get());
35 35
36 // Verify that we can't select it again since only one has been added. 36 // Verify that we can't select it again since only one has been added.
37 collection_.SelectAudioRenderer(&audio_renderer); 37 collection_.SelectAudioRenderer(&audio_renderer);
38 EXPECT_FALSE(audio_renderer); 38 EXPECT_FALSE(audio_renderer);
39 } 39 }
40 40
41 TEST_F(FilterCollectionTest, MultipleFiltersOfSameType) { 41 TEST_F(FilterCollectionTest, MultipleFiltersOfSameType) {
42 scoped_refptr<AudioRenderer> audio_renderer_a(new MockAudioRenderer()); 42 scoped_refptr<AudioRenderer> audio_renderer_a(new MockAudioRenderer());
43 scoped_refptr<AudioRenderer> audio_renderer_b(new MockAudioRenderer()); 43 scoped_refptr<AudioRenderer> audio_renderer_b(new MockAudioRenderer());
44 44
45 scoped_refptr<AudioRenderer> audio_renderer; 45 scoped_refptr<AudioRenderer> audio_renderer;
46 46
47 collection_.AddAudioRenderer(audio_renderer_a.get()); 47 collection_.AddAudioRenderer(audio_renderer_a.get());
48 collection_.AddAudioRenderer(audio_renderer_b.get()); 48 collection_.AddAudioRenderer(audio_renderer_b.get());
49 49
50 // Verify that first SelectAudioRenderer() returns audio_renderer_a. 50 // Verify that first SelectAudioRenderer() returns audio_renderer_a.
51 collection_.SelectAudioRenderer(&audio_renderer); 51 collection_.SelectAudioRenderer(&audio_renderer);
52 EXPECT_TRUE(audio_renderer); 52 EXPECT_TRUE(audio_renderer.get());
53 EXPECT_EQ(audio_renderer, audio_renderer_a); 53 EXPECT_EQ(audio_renderer, audio_renderer_a);
54 54
55 // Verify that second SelectAudioRenderer() returns audio_renderer_b. 55 // Verify that second SelectAudioRenderer() returns audio_renderer_b.
56 collection_.SelectAudioRenderer(&audio_renderer); 56 collection_.SelectAudioRenderer(&audio_renderer);
57 EXPECT_TRUE(audio_renderer); 57 EXPECT_TRUE(audio_renderer.get());
58 EXPECT_EQ(audio_renderer, audio_renderer_b); 58 EXPECT_EQ(audio_renderer, audio_renderer_b);
59 59
60 // Verify that third SelectAudioRenderer() returns nothing. 60 // Verify that third SelectAudioRenderer() returns nothing.
61 collection_.SelectAudioRenderer(&audio_renderer); 61 collection_.SelectAudioRenderer(&audio_renderer);
62 EXPECT_FALSE(audio_renderer); 62 EXPECT_FALSE(audio_renderer);
63 } 63 }
64 64
65 } // namespace media 65 } // namespace media
OLDNEW
« no previous file with comments | « media/base/decoder_buffer_unittest.cc ('k') | media/base/mock_filters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698