Issue 11275022: Print diff-index when tree is dirty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11275022: Print diff-index when tree is dirty (Closed)

Created:
8 years, 2 months ago by Isaac (away)

Modified:
8 years, 2 months ago

Reviewers:
ukai, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Print diff-index when tree is dirty A common confusion when trying to upload is that the error messages does not provide a path to fixing the error. One example is the 'dirty-tree' message, which doesn't explain why gclient thinks the tree is dirty (which is harder to figure out with submodules). Print the diff-index output to make this more clear.

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	git_cl.py	View		3 chunks	+16 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

I kind of prefer https://chromiumcodereview.appspot.com/11262004/. But I think this should be refactored into a function.

8 years, 2 months ago (2012-10-25 01:58:22 UTC) #2

Isaac (away)

8 years, 2 months ago (2012-10-25 07:35:37 UTC) #3

abandoned.  Dupe with crrev.com/11262004/.  I checked crbug last weekend :-\

Expand Messages | Collapse Messages