Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_screen_network.js

Issue 11275011: Fix accessible label for network select control in OOBE. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove additional unnecessary line Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_screen_network.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Oobe network screen implementation. 6 * @fileoverview Oobe network screen implementation.
7 */ 7 */
8 8
9 cr.define('oobe', function() { 9 cr.define('oobe', function() {
10 /** 10 /**
(...skipping 25 matching lines...) Expand all
36 Oobe.setupSelect($('language-select'), 36 Oobe.setupSelect($('language-select'),
37 templateData.languageList, 37 templateData.languageList,
38 'networkOnLanguageChanged'); 38 'networkOnLanguageChanged');
39 39
40 Oobe.setupSelect($('keyboard-select'), 40 Oobe.setupSelect($('keyboard-select'),
41 templateData.inputMethodsList, 41 templateData.inputMethodsList,
42 'networkOnInputMethodChanged'); 42 'networkOnInputMethodChanged');
43 43
44 this.dropdown_ = $('networks-list'); 44 this.dropdown_ = $('networks-list');
45 cr.ui.DropDown.decorate(this.dropdown_); 45 cr.ui.DropDown.decorate(this.dropdown_);
46 this.dropdown_.setAttribute('aria-label',
47 localStrings.getString('selectNetwork'));
48 }, 46 },
49 47
50 onBeforeShow: function(data) { 48 onBeforeShow: function(data) {
51 cr.ui.DropDown.show('networks-list', true, -1); 49 cr.ui.DropDown.show('networks-list', true, -1);
52 }, 50 },
53 51
54 onBeforeHide: function() { 52 onBeforeHide: function() {
55 cr.ui.DropDown.hide('networks-list'); 53 cr.ui.DropDown.hide('networks-list');
56 }, 54 },
57 55
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 error.appendChild(messageDiv); 93 error.appendChild(messageDiv);
96 94
97 $('bubble').showContentForElement($('networks-list'), error, 95 $('bubble').showContentForElement($('networks-list'), error,
98 cr.ui.Bubble.Attachment.BOTTOM); 96 cr.ui.Bubble.Attachment.BOTTOM);
99 }; 97 };
100 98
101 return { 99 return {
102 NetworkScreen: NetworkScreen 100 NetworkScreen: NetworkScreen
103 }; 101 };
104 }); 102 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_screen_network.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698