- Represent strings internally in UTF-16 format, this makes it

vm/benchmark_test.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_BENCHMARK_TEST_H_
 #define VM_BENCHMARK_TEST_H_
 
 #include "include/dart_api.h"
 
 #include "vm/dart.h"
@@ skipping 17 matching lines @@
   void Dart_Benchmark##name(Benchmark* benchmark) {                            \
     FLAG_heap_growth_space_ratio = 100;                                        \
     BenchmarkIsolateScope __isolate__(benchmark);                              \
     StackZone __zone__(benchmark->isolate());                                  \
     HandleScope __hs__(benchmark->isolate());                                  \
     Dart_BenchmarkHelper##name(benchmark);                                     \
   }                                                                            \
   static void Dart_BenchmarkHelper##name(Benchmark* benchmark)
 
 
+#define NewString(str) Dart_NewStringFromCString(str)

[cshapiro, 2012/10/24 23:52:29]

This macro seems unnecessary.  Make this a static or inline function instead? 
Or, just do a string replace?  

Either way, we would be in closer agreement with the spirit style guide.

[siva, 2012/10/26 21:38:29]

Made an inline function doing a string replace results
in too many indentation issues.

On 2012/10/24 23:52:29, cshapiro wrote:

+
+
 class Benchmark {
  public:
   typedef void (RunEntry)(Benchmark* benchmark);
 
   Benchmark(RunEntry* run, const char* name) :
       run_(run),
       name_(name),
       score_(0),
       isolate_(NULL),
       next_(NULL) {
@@ skipping 57 matching lines @@
 
  private:
   Benchmark* benchmark_;
 
   DISALLOW_COPY_AND_ASSIGN(BenchmarkIsolateScope);
 };
 
 }  // namespace dart
 
 #endif  // VM_BENCHMARK_TEST_H_